From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga11.intel.com ([192.55.52.93]:53131 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753523Ab1FBRDA (ORCPT ); Thu, 2 Jun 2011 13:03:00 -0400 Subject: Re: [PATCH 07/10] iwlagn: advertise interface combinations From: wwguy To: Stanislaw Gruszka Cc: "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , "ipw3945-devel@lists.sourceforge.net" , "Berg, Johannes" In-Reply-To: <20110602162241.GE4580@redhat.com> References: <1306510833-32049-1-git-send-email-wey-yi.w.guy@intel.com> <1306510833-32049-8-git-send-email-wey-yi.w.guy@intel.com> <20110602162241.GE4580@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 02 Jun 2011 09:59:31 -0700 Message-ID: <1307033971.14344.4.camel@wwguy-ubuntu> (sfid-20110602_190304_456523_2AAB1F56) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2011-06-02 at 09:22 -0700, Stanislaw Gruszka wrote: > On Fri, May 27, 2011 at 08:40:30AM -0700, Wey-Yi Guy wrote: > > From: Johannes Berg > > > > With this, iwlwifi will advertise the limits on > > concurrency of virtual interfaces. > > John, please revert this patch, it disallow to register new device > with below error. I believe, Wey already asked you to not a apply it. > > WARNING: at net/wireless/core.c:468 wiphy_register+0x46e/0x5c0 > [cfg80211]() > Hardware name: HP xw8600 Workstation > Modules linked in: iwlagn(+) mac80211 cfg80211 fuse cpufreq_ondemand > acpi_cpufreq freq_table mperf xt_physdev ipt_REJECT nf_conntrack_ipv4 > nf_defrag_ipv4 iptable_filter ip_tables ip6t_REJECT nf_conntrack_ipv6 > nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables ipv6 > ext3 jbd dm_mirror dm_region_hash dm_log dm_mod uinput sg hp_wmi > sparse_keymap rfkill microcode serio_raw shpchp ext4 mbcache jbd2 sr_mod > cdrom sd_mod crc_t10dif firewire_ohci firewire_core crc_itu_t mptsas > mptscsih mptbase scsi_transport_sas ahci libahci pata_acpi ata_generic > ata_piix floppy nouveau ttm drm_kms_helper drm i2c_algo_bit i2c_core > mxm_wmi wmi video [last unloaded: scsi_wait_scan] > Pid: 7333, comm: firmware/iwlwif Not tainted 3.0.0-rc1-wl+ #82 > Call Trace: > [] warn_slowpath_common+0x7f/0xc0 > [] warn_slowpath_null+0x1a/0x20 > [] wiphy_register+0x46e/0x5c0 [cfg80211] > [] ? __kmalloc+0x1b3/0x2d0 > [] ? ieee80211_register_hw+0xde/0x670 [mac80211] > [] ieee80211_register_hw+0x28c/0x670 [mac80211] > [] iwl_ucode_callback+0xd3a/0x11d0 [iwlagn] > [] ? kobject_release+0xa7/0x1d0 > [] ? _request_firmware+0x4e0/0x4e0 > [] request_firmware_work_func+0x41/0x80 > [] kthread+0xb6/0xc0 > [] ? trace_hardirqs_on_caller+0x155/0x1a0 > [] kernel_thread_helper+0x4/0x10 > [] ? retint_restore_args+0x13/0x13 > [] ? __init_kthread_worker+0x70/0x70 > [] ? gs_change+0x13/0x13 > ---[ end trace 971e83aec02c096b ]--- > iwlagn 0000:80:00.0: Failed to register hw (error -22) hmm, I thought I ask John not to merge this patch, we also see the similar problem. Johannes has the fix already. John, Could you revert the patch, I will re-submit. Thanks Wey