From: Johannes Berg <johannes@sipsolutions.net>
To: duaneg@dghda.com
Cc: linux-wireless@vger.kernel.org, Luciano Coelho <coelho@ti.com>
Subject: Re: rfkill deadlock
Date: Fri, 03 Jun 2011 22:58:47 +0200 [thread overview]
Message-ID: <1307134727.3800.12.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20110603160049.GA8767@kereru>
On Fri, 2011-06-03 at 17:00 +0100, duaneg@dghda.com wrote:
> Hi there,
>
> I'm getting a deadlock with 3.0.0-rc1:
>
> Jun 3 12:06:20 kereru kernel: =======================================================
> Jun 3 12:06:20 kereru kernel: [ INFO: possible circular locking dependency detected ]
> Jun 3 12:06:20 kereru kernel: 3.0.0-rc1-00049-g1fa7b6a #57
> Jun 3 12:06:20 kereru kernel: -------------------------------------------------------
> Jun 3 12:06:20 kereru kernel: kworker/0:1/4525 is trying to acquire lock:
> Jun 3 12:06:20 kereru kernel: (&rdev->mtx){+.+.+.}, at: [<ffffffff8164c831>] cfg80211_netdev_notifier_call+0x131/0x5b0
> Jun 3 12:06:20 kereru kernel:
> Jun 3 12:06:20 kereru kernel: but task is already holding lock:
> Jun 3 12:06:20 kereru kernel: (&rdev->devlist_mtx){+.+.+.}, at: [<ffffffff8164dcef>] cfg80211_rfkill_set_block+0x4f/0xa0
> Jun 3 12:06:20 kereru kernel:
> Jun 3 12:06:20 kereru kernel: which lock already depends on the new lock.
This is caused by Luca's scheduled scan changes. The reason is that
cfg80211_rfkill_set_block holds devlist_mtx, but then he added
cfg80211_lock_rdev(rdev); to NETDEV_GOING_DOWN, which is of course
invoked by dev_close() in cfg80211_rfkill_set_block(). Thus, the
problem. Not sure what to do to solve it, I'll let him sort it out :)
johannes
next prev parent reply other threads:[~2011-06-03 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 16:00 rfkill deadlock duaneg
2011-06-03 20:58 ` Johannes Berg [this message]
2011-06-06 6:23 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307134727.3800.12.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=coelho@ti.com \
--cc=duaneg@dghda.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox