Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luciano Coelho <coelho@ti.com>
To: stable@kernel.org
Cc: gregkh@suse.de, linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH stable] nl80211: fix check for valid SSID size in scan operations
Date: Mon, 06 Jun 2011 22:35:30 +0300	[thread overview]
Message-ID: <1307388930.23002.422.camel@cumari> (raw)
In-Reply-To: <1307388656-19240-1-git-send-email-coelho@ti.com>

On Mon, 2011-06-06 at 22:30 +0300, Luciano Coelho wrote: 
> In both trigger_scan and sched_scan operations, we were checking for
> the SSID length before assigning the value correctly.  Since the
> memory was just kzalloc'ed, the check was always failing and SSID with
> over 32 characters were allowed to go through.
> 
> This was causing a buffer overflow when copying the actual SSID to the
> proper place.
> 
> This bug has been there since 2.6.29-rc4.
> 
> Backported from commit 208c72f4fe44fe09577e7975ba0e7fa0278f3d03.
> 
> Cc: stable@kernel.org
> Signed-off-by: Luciano Coelho <coelho@ti.com>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---

FWIW, this patch applies cleanly on all stable kernels at least as far
back as 2.6.35, probably even earlier.

-- 
Cheers,
Luca.


      reply	other threads:[~2011-06-06 19:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <13073811693022@kroah.org>
2011-06-06 19:30 ` [PATCH stable] nl80211: fix check for valid SSID size in scan operations Luciano Coelho
2011-06-06 19:35   ` Luciano Coelho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307388930.23002.422.camel@cumari \
    --to=coelho@ti.com \
    --cc=gregkh@suse.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox