From: Luciano Coelho <coelho@ti.com>
To: linville@tuxdriver.com, stable@kernel.org
Cc: linux-wireless@vger.kernel.org, ido@wizery.com,
johannes@sipsolutions.net
Subject: Re: [PATCH 3.0] nl80211: fix overflow in ssid_len
Date: Tue, 07 Jun 2011 21:25:35 +0300 [thread overview]
Message-ID: <1307471135.31669.15.camel@cumari> (raw)
In-Reply-To: <1307468546-16915-1-git-send-email-coelho@ti.com>
On Tue, 2011-06-07 at 20:42 +0300, Luciano Coelho wrote:
> When one of the SSID's length passed in a scan or sched_scan request
> is larger than 255, there will be an overflow in the u8 that is used
> to store the length before checking. This causes the check to fail
> and we overrun the buffer when copying the SSID.
>
> Fix this by checking the nl80211 attribute length before copying it to
> the struct.
>
> This is a follow up for the previous commit
> 208c72f4fe44fe09577e7975ba0e7fa0278f3d03, which didn't fix the problem
> entirely.
>
> Reported-by: Ido Yariv <ido@wizery.com>
> Signed-off-by: Luciano Coelho <coelho@ti.com>
> ---
This should also go to stable, but since it won't apply directly there,
I'll wait till it's applied upstream and then backport it to stable
kernels.
--
Cheers,
Luca.
prev parent reply other threads:[~2011-06-07 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 17:42 [PATCH 3.0] nl80211: fix overflow in ssid_len Luciano Coelho
2011-06-07 18:25 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307471135.31669.15.camel@cumari \
--to=coelho@ti.com \
--cc=ido@wizery.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox