From: Joe Perches <joe@perches.com>
To: Pavel Roskin <proski@gnu.org>
Cc: netdev@vger.kernel.org,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Jouni Malinen <jmalinen@atheros.com>,
Senthil Balasubramanian <senthilkumar@atheros.com>,
ath9k-devel@lists.ath9k.org, Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Vasanthakumar Thiagarajan <vasanth@atheros.com>,
Christian Lamparter <chunkeey@googlemail.com>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void *
Date: Tue, 14 Jun 2011 09:43:51 -0700 [thread overview]
Message-ID: <1308069831.21026.9.camel@Joe-Laptop> (raw)
In-Reply-To: <4DF78CEC.70409@gnu.org>
On Tue, 2011-06-14 at 12:31 -0400, Pavel Roskin wrote:
> On 06/14/2011 12:02 AM, Joe Perches wrote:
> > /* Get the message ID */
> > - msg_id = (__be16 *) ((void *) htc_hdr +
> > - sizeof(struct htc_frame_hdr));
> > + msg_id = (void *)htc_hdr + sizeof(struct htc_frame_hdr);
> I would never do stuff like this without verifying by sparse that no
> warnings are introduced.
I did that. I believe there are no new warnings.
> Sparse warnings should be avoided to keep sparse checks useful.
> Otherwise, important warnings would drown in the noise.
$ make allyesconfig
$ git log -1 --pretty=oneline drivers/net/wireless/ath/ath9k/htc_hst.c
337c22b774ff7f007b90b266b25c9a33ff555c48 wireless: Remove casts of void *
$ make C=2 drivers/net/wireless/ath/ath9k/htc_hst.o
make[1]: Nothing to be done for `all'.
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHECK scripts/mod/empty.c
CHECK drivers/net/wireless/ath/ath9k/htc_hst.c
CC drivers/net/wireless/ath/ath9k/htc_hst.o
$
next prev parent reply other threads:[~2011-06-14 16:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 4:02 [PATCH net-next 0/2] drivers/net: Remove casts of void * Joe Perches
2011-06-14 4:02 ` [PATCH net-next 1/2] wireless: " Joe Perches
2011-06-14 5:23 ` Julian Calaby
2011-06-14 5:32 ` Joe Perches
2011-06-14 5:39 ` Julian Calaby
2011-06-14 7:19 ` Joe Perches
2011-06-14 8:45 ` Bing Zhao
2011-06-14 8:46 ` Bing Zhao
2011-06-14 16:31 ` [ath9k-devel] " Pavel Roskin
2011-06-14 16:43 ` Joe Perches [this message]
2011-06-14 17:43 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308069831.21026.9.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=chunkeey@googlemail.com \
--cc=ilw@linux.intel.com \
--cc=jmalinen@atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=proski@gnu.org \
--cc=senthilkumar@atheros.com \
--cc=sgruszka@redhat.com \
--cc=vasanth@atheros.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).