From: wwguy <wey-yi.w.guy@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ipw3945-devel@lists.sourceforge.net"
<ipw3945-devel@lists.sourceforge.net>
Subject: Re: [PATCH 01/18] iwlagn: usersapce application decide the size of trace buffer
Date: Sun, 19 Jun 2011 09:05:37 -0700 [thread overview]
Message-ID: <1308499537.31756.14.camel@wwguy-ubuntu> (raw)
In-Reply-To: <1308470852.4145.2.camel@jlt3.sipsolutions.net>
On Sun, 2011-06-19 at 01:07 -0700, Johannes Berg wrote:
> On Sat, 2011-06-11 at 07:25 -0700, Wey-Yi Guy wrote:
>
> > +++ b/drivers/net/wireless/iwlwifi/iwl-testmode.h
> > @@ -167,6 +167,7 @@ enum iwl_tm_attr_t {
> > */
> > IWL_TM_ATTR_TRACE_ADDR,
> > IWL_TM_ATTR_TRACE_DATA,
> > + IWL_TM_ATTR_TRACE_SIZE,
> >
> > /* When IWL_TM_ATTR_COMMAND is IWL_TM_CMD_APP2DEV_FIXRATE_REQ,
> > * The mandatory fields are:
>
> I know that currently there are no applications, but I really think we
> need to be much more careful about this as it is quickly becoming ABI,
> so you can't just insert attributes in the middle.
>
point taken, I will continue work in this area and will try to see how
to address this issue in my following patches
Thanks
Wey
>
next prev parent reply other threads:[~2011-06-19 16:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-11 14:25 [PATCH 00/18] update for 3.1 Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 01/18] iwlagn: usersapce application decide the size of trace buffer Wey-Yi Guy
2011-06-19 8:07 ` Johannes Berg
2011-06-19 16:05 ` wwguy [this message]
2011-06-11 14:25 ` [PATCH 02/18] iwlagn: add dumpit support for testmode trace function Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 03/18] iwlagn: move bt_coex_active as part of iwlagn_mod_params Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 04/18] iwlagn: move led_mode " Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 05/18] iwlagn: move no_sleep_autoadjust " Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 06/18] iwlagn: don't check ucode subtype Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 07/18] iwlagn: Band capabilities in EEPROM Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 08/18] iwlagn: use sku capabilities information from EEPROM Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 09/18] iwlagn: add coex debug flag Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 10/18] iwlagn: add debug message for coex related activities Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 11/18] iwlagn: use IWL_DEBUG_TEMP for temperature related debug Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 12/18] iwlagn: use IWL_DEBUG_FW for firmware related debug msg Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 13/18] iwlagn: remove unused debug flag Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 14/18] iwlagn: generic temperature location in EEPROM Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 15/18] iwlagn: group similar defines together Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 16/18] iwlagn: merge duplicated code into single place Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 17/18] iwlagn: Sanity check for 11n capability Wey-Yi Guy
2011-06-11 14:25 ` [PATCH 18/18] iwlagn: Sanity check for valid context Wey-Yi Guy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308499537.31756.14.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox