From: wwguy <wey-yi.w.guy@intel.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwlagn: fix rmmod crash
Date: Fri, 24 Jun 2011 07:02:15 -0700 [thread overview]
Message-ID: <1308924135.19001.1.camel@wwguy-ubuntu> (raw)
In-Reply-To: <1308908074-4163-1-git-send-email-sgruszka@redhat.com>
On Fri, 2011-06-24 at 02:34 -0700, Stanislaw Gruszka wrote:
> priv->bus.bus_specific pointer is used after priv structures was freed,
> in iwl_pci_remove(), what make ugly rmmod crash. This bug was introduced
> by current pci changes.
>
> On the way remove fake check, if prober error code is returned from
> .probe() function, .remove() will never be called be null drvdata.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> ---
you are right, thank you very much for catch this.
Wey
prev parent reply other threads:[~2011-06-24 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 9:34 [PATCH] iwlagn: fix rmmod crash Stanislaw Gruszka
2011-06-24 10:42 ` Emmanuel Grumbach
2011-06-24 14:02 ` wwguy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308924135.19001.1.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox