From: Johannes Berg <johannes@sipsolutions.net>
To: Alexander Simon <alexander.simon@saxnet.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: patch for iw
Date: Mon, 27 Jun 2011 14:42:20 +0200 [thread overview]
Message-ID: <1309178540.3911.14.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1308672087.2656.13.camel@alex-2> (sfid-20110621_180135_800515_518FC79B)
On Tue, 2011-06-21 at 18:01 +0200, Alexander Simon wrote:
> @@ -44,6 +45,12 @@ static int join_ibss(struct nl80211_stat
> argv++;
> argc--;
>
> + if (argc && parse_channel_type(argv[0], &htval)) {
> + NLA_PUT_U32(msg, NL80211_ATTR_WIPHY_CHANNEL_TYPE, htval);
> + argv++;
> + argc--;
> + }
> +/*
> + * Convert a string "HT20", "HT40+" or "HT40-" into nl80211
> + * value. Conversion is case insensitive. Returns 1 on success, 0 on error.
> + */
> +
> +int parse_channel_type(const char *str, unsigned int *htval)
That return value isn't the way other functions return their status in
iw, so I won't apply this, it'll just confuse things.
johannes
next prev parent reply other threads:[~2011-06-27 12:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 15:45 [RFC v3 1/3] mac80211: add some helper functions Alexander Simon
2011-06-21 15:52 ` [RFC v3 2/3] nl80211: channel type attribute for IBSS Alexander Simon
2011-06-24 18:56 ` Felix Fietkau
2011-07-04 10:07 ` Alexander Simon
2011-07-04 10:10 ` Johannes Berg
2011-06-27 12:46 ` Johannes Berg
2011-06-21 15:53 ` [RFC v3 3/3] mac80211: HT operation in IBSS Alexander Simon
2011-06-24 19:21 ` Felix Fietkau
2011-06-27 12:50 ` Johannes Berg
2011-06-27 12:51 ` Johannes Berg
2011-06-21 16:01 ` patch for iw Alexander Simon
2011-06-27 12:42 ` Johannes Berg [this message]
2011-06-21 16:02 ` [RFC v3 1/3] mac80211: add some helper functions Johannes Berg
2011-06-24 19:01 ` Felix Fietkau
2011-06-27 12:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309178540.3911.14.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=alexander.simon@saxnet.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).