linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Franky Lin" <frankyl@broadcom.com>
To: gregkh@suse.de
Cc: devel@linuxdriverproject.org, linux-wireless@vger.kernel.org
Subject: [PATCH 069/119] staging: brcm80211: remove TOE macro definition
Date: Wed, 29 Jun 2011 16:47:33 -0700	[thread overview]
Message-ID: <1309391303-22741-70-git-send-email-frankyl@broadcom.com> (raw)
In-Reply-To: <1309391303-22741-1-git-send-email-frankyl@broadcom.com>

From: Arend van Spriel <arend@broadcom.com>

The code conditional by TOE macro is always needed so TOE macro
usage has been removed from the fullmac sources.

Signed-off-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
---
 drivers/staging/brcm80211/brcmfmac/Makefile    |    3 +--
 drivers/staging/brcm80211/brcmfmac/dhd_linux.c |   14 --------------
 2 files changed, 1 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/brcm80211/brcmfmac/Makefile b/drivers/staging/brcm80211/brcmfmac/Makefile
index c97e5bb..7441649 100644
--- a/drivers/staging/brcm80211/brcmfmac/Makefile
+++ b/drivers/staging/brcm80211/brcmfmac/Makefile
@@ -21,8 +21,7 @@ ccflags-y :=			\
 	-DBRCMF_FIRSTREAD=64	\
 	-DBRCMF_SDALIGN=64	\
 	-DMAX_HDR_READ=64	\
-	-DSHOW_EVENTS		\
-	-DTOE
+	-DSHOW_EVENTS
 
 ccflags-$(CONFIG_BRCMDBG)	+= -DDHD_DEBUG
 
diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c
index 8a2c73d..0764d02 100644
--- a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c
+++ b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c
@@ -364,12 +364,8 @@ module_param(brcmf_pktgen_len, uint, 0);
 #endif
 
 static void brcmf_dpc(unsigned long data);
-
-#ifdef TOE
 static int brcmf_toe_get(dhd_info_t *dhd, int idx, u32 *toe_ol);
 static int brcmf_toe_set(dhd_info_t *dhd, int idx, u32 toe_ol);
-#endif				/* TOE */
-
 static int brcmf_host_event(dhd_info_t *dhd, int *ifidx, void *pktdata,
 			     brcmf_event_msg_t *event_ptr, void **data_ptr);
 
@@ -1315,7 +1311,6 @@ void brcmf_sched_dpc(dhd_pub_t *dhdp)
 	tasklet_schedule(&dhd->tasklet);
 }
 
-#ifdef TOE
 /* Retrieve current toe component enables, which are kept
 	 as a bitmap in toe_ol iovar */
 static int brcmf_toe_get(dhd_info_t *dhd, int ifidx, u32 *toe_ol)
@@ -1393,7 +1388,6 @@ static int brcmf_toe_set(dhd_info_t *dhd, int ifidx, u32 toe_ol)
 
 	return 0;
 }
-#endif				/* TOE */
 
 static void brcmf_ethtool_get_drvinfo(struct net_device *net,
 				    struct ethtool_drvinfo *info)
@@ -1415,11 +1409,9 @@ static int brcmf_ethtool(dhd_info_t *dhd, void *uaddr)
 	struct ethtool_drvinfo info;
 	char drvname[sizeof(info.driver)];
 	u32 cmd;
-#ifdef TOE
 	struct ethtool_value edata;
 	u32 toe_cmpnt, csum_dir;
 	int ret;
-#endif
 
 	DHD_TRACE(("%s: Enter\n", __func__));
 
@@ -1464,7 +1456,6 @@ static int brcmf_ethtool(dhd_info_t *dhd, void *uaddr)
 			 (int)sizeof(drvname), drvname, info.driver));
 		break;
 
-#ifdef TOE
 		/* Get toe offload components from dongle */
 	case ETHTOOL_GRXCSUM:
 	case ETHTOOL_GTXCSUM:
@@ -1516,7 +1507,6 @@ static int brcmf_ethtool(dhd_info_t *dhd, void *uaddr)
 		}
 
 		break;
-#endif				/* TOE */
 
 	default:
 		return -EOPNOTSUPP;
@@ -1665,9 +1655,7 @@ static int brcmf_netdev_stop(struct net_device *net)
 static int brcmf_netdev_open(struct net_device *net)
 {
 	dhd_info_t *dhd = *(dhd_info_t **) netdev_priv(net);
-#ifdef TOE
 	u32 toe_ol;
-#endif
 	int ifidx = brcmf_net2idx(dhd, net);
 	s32 ret = 0;
 
@@ -1685,14 +1673,12 @@ static int brcmf_netdev_open(struct net_device *net)
 
 		memcpy(net->dev_addr, dhd->pub.mac, ETH_ALEN);
 
-#ifdef TOE
 		/* Get current TOE mode from dongle */
 		if (brcmf_toe_get(dhd, ifidx, &toe_ol) >= 0
 		    && (toe_ol & TOE_TX_CSUM_OL) != 0)
 			dhd->iflist[ifidx]->net->features |= NETIF_F_IP_CSUM;
 		else
 			dhd->iflist[ifidx]->net->features &= ~NETIF_F_IP_CSUM;
-#endif
 	}
 	/* Allow transmit calls */
 	netif_start_queue(net);
-- 
1.7.1



  parent reply	other threads:[~2011-06-29 23:48 UTC|newest]

Thread overview: 142+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29 23:46 [PATCH 000/119] staging: brcm80211: more code cleanup and bug fixed Franky Lin
2011-06-29 23:46 ` [PATCH 001/119] staging: brcm80211: fix checkpatch errors in types.h Franky Lin
2011-06-29 23:46 ` [PATCH 002/119] staging:brcm80211:brcmfmac: CONNECTING status bit is set at appropriate location Franky Lin
2011-06-29 23:46 ` [PATCH 003/119] staging: brcm80211: remove flash related code from initvars_srom_pci() Franky Lin
2011-06-29 23:46 ` [PATCH 004/119] staging: brcm80211: minor cleanup in initvars_srom_pci() Franky Lin
2011-06-29 23:46 ` [PATCH 005/119] staging: brcm80211: make use of linux error codes in srom.c Franky Lin
2011-06-29 23:46 ` [PATCH 006/119] staging: brcm80211: remove unused sdtxlock from fullmac Franky Lin
2011-06-29 23:46 ` [PATCH 007/119] staging: brcm80211: remove empty sdrxqlock " Franky Lin
2011-06-29 23:46 ` [PATCH 008/119] staging: brcm80211: move sdtxqlock codes to dhd_sdio.c Franky Lin
2011-06-29 23:46 ` [PATCH 009/119] staging: brcm80211: remove unused files from fullmac Franky Lin
2011-06-29 23:46 ` [PATCH 010/119] staging: brcm80211: remove code for unsupported chipsets from brcmsmac Franky Lin
2011-06-29 23:46 ` [PATCH 011/119] staging: brcm80211: remove unsupported chipset code from brcmsmac phy Franky Lin
2011-06-29 23:46 ` [PATCH 012/119] staging: brcm80211: remove otp power control functions Franky Lin
2011-06-29 23:46 ` [PATCH 013/119] staging: brcm80211: remove code from pmu.c related to unsupported chipsets Franky Lin
2011-06-29 23:46 ` [PATCH 014/119] staging: brcm80211: remove unused macro definitions from pmu.c Franky Lin
2011-06-29 23:46 ` [PATCH 015/119] staging: brcm80211: remove chip simulation specific code Franky Lin
2011-06-29 23:46 ` [PATCH 016/119] staging: brcm80211: remove macro FOREACH_AS_STA Franky Lin
2011-06-29 23:46 ` [PATCH 017/119] staging: brcm80211: change FOREACH_BSS macro to remove checkpatch error Franky Lin
2011-06-30  8:37   ` Dan Carpenter
2011-06-30 10:19     ` Arend van Spriel
2011-07-05 14:11       ` Arend van Spriel
2011-07-05 16:59         ` Greg KH
2011-06-29 23:46 ` [PATCH 018/119] staging: brcm80211: remove macro definition DRV_MODULE_NAME Franky Lin
2011-06-29 23:46 ` [PATCH 019/119] staging: brcm80211: get rid on IS_CFG80211_FAVORITE macro Franky Lin
2011-06-29 23:46 ` [PATCH 020/119] staging: brcm80211: move assert function to dhd_linux.c Franky Lin
2011-06-29 23:46 ` [PATCH 021/119] staging: brcm80211: parsed ADDBA response ack window parameter Franky Lin
2011-06-29 23:46 ` [PATCH 022/119] staging: brcm80211: taking max AMPDU length advertized by peer into account Franky Lin
2011-06-29 23:46 ` [PATCH 023/119] staging: brcm80211: corrected tx status feedback for non AMPDU packets Franky Lin
2011-06-29 23:46 ` [PATCH 024/119] staging: brcm80211: Changed comments Franky Lin
2011-06-29 23:46 ` [PATCH 025/119] staging: brcm80211: removed unneeded 'if' statement Franky Lin
2011-06-29 23:46 ` [PATCH 026/119] staging: brcm80211: delete empty brcmfmac/README file Franky Lin
2011-06-29 23:46 ` [PATCH 027/119] staging: brcm80211: run scripts/cleanfile to remove whitespace errors Franky Lin
2011-06-29 23:46 ` [PATCH 028/119] staging: brcm80211: cleanup " Franky Lin
2011-06-29 23:46 ` [PATCH 029/119] staging: brcm80211: add missing KERN_ facility level to printk() Franky Lin
2011-06-29 23:46 ` [PATCH 030/119] staging: brcm80211: flatten wlc_phy_shared_detach() Franky Lin
2011-06-29 23:46 ` [PATCH 031/119] staging: brcm80211: remove unnecessary null check Franky Lin
2011-06-29 23:46 ` [PATCH 032/119] staging: brcm80211: reorg brcms_c_validboardtype for clarity Franky Lin
2011-06-29 23:46 ` [PATCH 033/119] staging: brcm80211: correct bcmsdh_recv_buf() calls Franky Lin
2011-06-29 23:46 ` [PATCH 034/119] staging: brcm80211: remove wireless extensions support from brcmfmac Franky Lin
2011-06-29 23:46 ` [PATCH 035/119] staging: brcm80211: replaced prefix of SDIO related functions Franky Lin
2011-06-29 23:47 ` [PATCH 036/119] staging: brcm80211: remove dhd_set_timer function prototype Franky Lin
2011-06-29 23:47 ` [PATCH 037/119] staging: brcm80211: remove unused globals from dhd_common.c Franky Lin
2011-06-29 23:47 ` [PATCH 038/119] staging: brcm80211: remove extern function prototypes from c files Franky Lin
2011-06-29 23:47 ` [PATCH 039/119] staging: brcm80211: rename functions and variables in dhd_common.c Franky Lin
2011-06-29 23:47 ` [PATCH 040/119] staging: brcm80211: rename ioctl command codes in dhd.h Franky Lin
2011-06-29 23:47 ` [PATCH 041/119] staging: brcm80211: remove unused definitions from dhd.h Franky Lin
2011-06-29 23:47 ` [PATCH 042/119] staging: brcm80211: replace macro BCM_MSG_IFNAME_MAX with IFNAMSIZ Franky Lin
2011-06-29 23:47 ` [PATCH 043/119] staging: brcm80211: rename event handling definition Franky Lin
2011-06-29 23:47 ` [PATCH 044/119] staging: brcm80211: rename module parameters Franky Lin
2011-06-29 23:47 ` [PATCH 045/119] staging: brcm80211: remove unnecessary abstraction for scheduler Franky Lin
2011-06-29 23:47 ` [PATCH 046/119] staging: brcm80211: rename fullmac functions Franky Lin
2011-06-29 23:47 ` [PATCH 047/119] staging: brcm80211: remove unused prototypes from dhd.h Franky Lin
2011-06-29 23:47 ` [PATCH 048/119] staging: brcm80211: removed BDC defines Franky Lin
2011-06-29 23:47 ` [PATCH 049/119] staging: brcm80211: rename fullmac protocol related functions Franky Lin
2011-06-29 23:47 ` [PATCH 050/119] staging: brcm80211: get rid of PKT[TO/FROM]NATIVE macros Franky Lin
2011-06-29 23:47 ` [PATCH 051/119] staging: brcm80211: rename dhd_prot and get rid of dhd_prot_t typedef Franky Lin
2011-06-29 23:47 ` [PATCH 052/119] staging: brcm80211: remove conditional SIMPLE_ISCAN code Franky Lin
2011-06-29 23:47 ` [PATCH 053/119] staging: brcm80211: rename netdevice related functions in fullmac Franky Lin
2011-06-29 23:47 ` [PATCH 054/119] staging: brcm80211: rename static functions in dhd_linux.c Franky Lin
2011-06-29 23:47 ` [PATCH 055/119] staging: brcm80211: rename more brcmfmac module parameters Franky Lin
2011-06-29 23:47 ` [PATCH 056/119] staging: brcm80211: replaced typedef sdioh_info_t by struct sdioh_info Franky Lin
2011-06-29 23:47 ` [PATCH 057/119] staging: brcm80211: replaced typedef bcmsdh_info_t by struct brcmf_sdio Franky Lin
2011-06-29 23:47 ` [PATCH 058/119] staging: brcm80211: replaced typedef by struct for several sdio types Franky Lin
2011-06-29 23:47 ` [PATCH 059/119] staging: brcm80211: replaced typedef SDIOH_API_RC by int Franky Lin
2011-06-29 23:47 ` [PATCH 060/119] staging: brcm80211: replaced more sdio related typedefs by structs Franky Lin
2011-06-29 23:47 ` [PATCH 061/119] staging: brcm80211: further renaming in fullmac sources Franky Lin
2011-07-05  7:36   ` Dan Carpenter
2011-07-05 14:15     ` Roland Vossen
2011-07-05 17:38       ` Dan Carpenter
2011-06-29 23:47 ` [PATCH 062/119] staging: brcm80211: remove ARP_OFFLOAD_SUPPORT macro definition Franky Lin
2011-06-29 23:47 ` [PATCH 063/119] staging: brcm80211: remove PKT_FILTER_SUPPORT " Franky Lin
2011-06-29 23:47 ` [PATCH 064/119] staging: brcm80211: remove BCMLXSDMMC " Franky Lin
2011-06-29 23:47 ` [PATCH 065/119] staging: brcm80211: always enable code for PLATFORM_BUS functionality Franky Lin
2011-06-29 23:47 ` [PATCH 066/119] staging: brcm80211: remove DHD_SCHED macro definition Franky Lin
2011-06-29 23:47 ` [PATCH 067/119] staging: brcm80211: remove EMBEDDED_PLATFORM " Franky Lin
2011-06-29 23:47 ` [PATCH 068/119] staging: brcm80211: remove MMC_SDIO_ABORT " Franky Lin
2011-06-29 23:47 ` Franky Lin [this message]
2011-06-29 23:47 ` [PATCH 070/119] staging: brcm80211: define SHOW_EVENTS macro only for debugging Franky Lin
2011-06-29 23:47 ` [PATCH 071/119] staging: brcm80211: replace DHD_DEBUG macro with BCMDBG Franky Lin
2011-06-29 23:47 ` [PATCH 072/119] staging: brcm80211: remove unnecessary macro defintions Franky Lin
2011-06-29 23:47 ` [PATCH 073/119] staging: brcm80211: remove custom gpio support code Franky Lin
2011-06-29 23:47 ` [PATCH 074/119] staging: brcm80211: remove conditional code fragments from brcmfmac Franky Lin
2011-06-29 23:47 ` [PATCH 075/119] staging: brcm80211: rename EPI_VERSION_STR macro Franky Lin
2011-06-29 23:47 ` [PATCH 076/119] staging: brcm80211: use linux native ethertype iso ETH_P_BRCM Franky Lin
2011-06-29 23:47 ` [PATCH 077/119] staging: brcm80211: move sdio related suspend/resume code to bus interface layer Franky Lin
2011-06-29 23:47 ` [PATCH 078/119] staging: brcm80211: move waitqueue code to dhd_sdio.c Franky Lin
2011-06-29 23:47 ` [PATCH 079/119] staging: brcm80211: move fullmac watchdog timer " Franky Lin
2011-06-29 23:47 ` [PATCH 080/119] staging: brcm80211: move debug console related " Franky Lin
2011-06-29 23:47 ` [PATCH 081/119] staging: brcm80211: move dpc " Franky Lin
2011-06-29 23:47 ` [PATCH 082/119] staging: brcm80211: move sdio resource lock " Franky Lin
2011-06-29 23:47 ` [PATCH 083/119] staging: brcm80211: clean up firmware download code in fullmac Franky Lin
2011-06-29 23:47 ` [PATCH 084/119] staging: brcm80211: rename function variables Franky Lin
2011-06-29 23:47 ` [PATCH 085/119] staging: brcm80211: remove unused definitions from dhd.h Franky Lin
2011-06-29 23:47 ` [PATCH 086/119] staging: brcm80211: rename structure definitions in dhd.h Franky Lin
2011-06-29 23:47 ` [PATCH 087/119] staging: brcm80211: rename macro " Franky Lin
2011-06-29 23:47 ` [PATCH 088/119] staging: brcm80211: remove unused macro definitions from dhd.h Franky Lin
2011-06-29 23:47 ` [PATCH 089/119] staging: brcm80211: structure renaming in dhd.h Franky Lin
2011-06-29 23:47 ` [PATCH 090/119] staging: brcm80211: rename structure definitions in dhd_linux.c Franky Lin
2011-06-29 23:47 ` [PATCH 091/119] staging: brcm80211: rename struct dhd_pub to struct brcmf_pub Franky Lin
2011-06-29 23:47 ` [PATCH 092/119] staging: brmc80211: cleaned up sdio related error codes Franky Lin
2011-06-29 23:47 ` [PATCH 093/119] staging: brcm80211: removed global function declarations from .c files Franky Lin
2011-06-29 23:47 ` [PATCH 094/119] staging: brcm80211: removed last occurrences of bcmsdh/BCMSDH Franky Lin
2011-07-05  9:59   ` Dan Carpenter
2011-07-05 12:31     ` Arend van Spriel
2011-06-29 23:47 ` [PATCH 095/119] staging: brcm80211: sdh related code cleanup Franky Lin
2011-06-29 23:48 ` [PATCH 096/119] staging: brcm80211: removed brcmf_sdioh_interrupt_pending() Franky Lin
2011-06-29 23:48 ` [PATCH 097/119] staging: brcm80211: removed brcmf_sdioh_reset() Franky Lin
2011-06-29 23:48 ` [PATCH 098/119] staging: brcm80211: removed brcmf_sdioh_start() and brcmf_sdioh_stop() Franky Lin
2011-06-29 23:48 ` [PATCH 099/119] staging: brcm80211: removed file sdiovar.h Franky Lin
2011-06-29 23:48 ` [PATCH 100/119] staging: brcm80211: further cleaned fullmac header files Franky Lin
2011-06-29 23:48 ` [PATCH 101/119] staging: brcm80211: removed last global function declaration in .c file Franky Lin
2011-06-29 23:48 ` [PATCH 102/119] staging: brcm80211: rename function variables Franky Lin
2011-06-29 23:48 ` [PATCH 103/119] staging: brcm80211: remove unused macros from dhd_dbg.h Franky Lin
2011-06-29 23:48 ` [PATCH 104/119] staging: brcm80211: rename dhd_bus structure and functions Franky Lin
2011-06-29 23:48 ` [PATCH 105/119] staging: brcm80211: rename static functions in wl_cfg80211.c Franky Lin
2011-06-29 23:48 ` [PATCH 106/119] staging: brcm80211: removed last typedefs from fullmac Franky Lin
2011-06-29 23:48 ` [PATCH 107/119] staging: brcm80211: removed unused code and definitions " Franky Lin
2011-06-29 23:48 ` [PATCH 108/119] staging: brcm80211: fullmac register access macro's take u32 instead of pointers Franky Lin
2011-06-29 23:48 ` [PATCH 109/119] staging: brcm80211: replaced macro R_SDREG by function r_sdreg() Franky Lin
2011-06-29 23:48 ` [PATCH 110/119] staging: brcm80211: replaced macro W_SDREG by function w_sdreg() Franky Lin
2011-06-29 23:48 ` [PATCH 111/119] staging: brcm80211: got rid of redundant member 'regs' of struct dhd_bus Franky Lin
2011-06-29 23:48 ` [PATCH 112/119] staging: brcm80211: removed last amd64 compiler warnings Franky Lin
2011-06-29 23:48 ` [PATCH 113/119] staging: brcm80211: W_REG macro cleanup in fullmac SDIO Franky Lin
2011-06-29 23:48 ` [PATCH 114/119] staging: brcm80211: removed unused definitions from dhd_sdio.c Franky Lin
2011-06-29 23:48 ` [PATCH 115/119] staging: brcm80211: rename structures and variables in wl_cfg80211.c Franky Lin
2011-06-29 23:48 ` [PATCH 116/119] staging: brcm80211: rename pointer conversion macros in wl_cfg80211.h Franky Lin
2011-06-29 23:48 ` [PATCH 117/119] staging: brcm80211: rename external function in wl_cfg80211.c Franky Lin
2011-06-29 23:48 ` [PATCH 118/119] staging: brcm80211: fix for reported log spam problem Franky Lin
2011-06-29 23:48 ` [PATCH 119/119] staging: brcm80211: updated TODO file Franky Lin
2011-06-30  6:29 ` [PATCH 000/119] staging: brcm80211: more code cleanup and bug fixed Rafał Miłecki
2011-06-30  6:59   ` Arend van Spriel
2011-06-30 17:42   ` Henry Ptasinski
2011-06-30 18:32     ` Dan Carpenter
2011-06-30 21:40       ` Henry Ptasinski
2011-07-01  0:05         ` Dan Carpenter
2011-07-01  0:14           ` Greg KH
2011-06-30 20:16     ` Luciano Coelho
2011-06-30 21:22       ` Henry Ptasinski
2011-07-05 16:59 ` Greg KH
2011-07-05 19:15   ` Arend van Spriel
2011-07-05 19:46     ` Arend van Spriel
2011-07-06  1:58       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309391303-22741-70-git-send-email-frankyl@broadcom.com \
    --to=frankyl@broadcom.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@suse.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).