From: Wojciech Dubowik <dubowoj@neratec.com>
To: Nikolay Ledovskikh <nledovskikh@gmail.com>
Cc: linux-wireless@vger.kernel.org, nbd <nbd@openwrt.org>
Subject: Re: [PATCH] ath5k: Use mips generic dma-mapping functions to avoid seqfault on AHB chips
Date: Wed, 23 Feb 2011 11:18:53 +0100 (CET) [thread overview]
Message-ID: <13107431.38.1298456333929.JavaMail.wlan@500181> (raw)
In-Reply-To: <AANLkTimP1r1A6nzcfh7kP=Hmcq9Cgha5Du28hE3zOs0x@mail.gmail.com>
> So, the problems are in openwrt platform patches that should be
> rewriten:
> 1. Changes needed to avoid using code like "mem=res->start" without
> ioremap.
> 2. Changes needed to avoid using NULL in first argument of
> dma_alloc_coherent and others.
>
> Without these changes ahb patch won't get into the kernel and we'll be
> lack of wisoc devices support?
> Is there any chance for the patch to get into the kernel and what
> should be done for it?
I can confirm that the problem is not in the driver but in openwrt
code. Dma mapping is assuming it has to shift address to pci bar
no matter whether PCI is enabled or not.
It seems to work on devices which don't have AHB arbitration
and PCI core. Somehow dma doesn't mind that destination address
with extra 0x2 at the beginning. Or at least it doesn't crash.
Also physical addresses need to be consistent in platform code which
is not the case at the moment. I am working now on the patch to fix it
in openwrt.
To get ar231x platform into the kernel is another story but if it
was done for ar71xx it just matter of some effort. Actually is
anyone working on it? It would allow to use platform code in the
wireless driver without extensive patching.
Cheers,
Wojtek
>
> (PS: Sorry for my english.)
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-23 10:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 19:09 [PATCH] ath5k: Use mips generic dma-mapping functions to avoid seqfault on AHB chips Nikolay Ledovskikh
2011-02-15 19:40 ` Jiri Slaby
[not found] ` <AANLkTiks9rG2CzM2LabNerK3zgJ+R+weytQgvXxDbNe7@mail.gmail.com>
2011-02-15 20:42 ` Jiri Slaby
2011-02-15 20:57 ` Nikolay Ledovskikh
2011-02-15 21:03 ` Jiri Slaby
2011-02-15 21:18 ` Nikolay Ledovskikh
2011-02-15 21:39 ` Nikolay Ledovskikh
2011-02-15 22:16 ` Jiri Slaby
2011-02-15 22:18 ` Jiri Slaby
[not found] ` <20110216011203.GA5773@linux-mips.org>
2011-02-16 10:26 ` Nikolay Ledovskikh
2011-02-23 10:18 ` Wojciech Dubowik [this message]
[not found] <AANLkTi=6jVGZx0oQdMQmndCB9k_xPywfntsB1LS_4ekM@mail.gmail.com>
2011-02-15 18:58 ` John W. Linville
[not found] <AANLkTinqN4MjWz4y5D195f9J8vob42GsG9u39xX-RuJf@mail.gmail.com>
2011-02-15 14:44 ` me
2011-02-15 14:49 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13107431.38.1298456333929.JavaMail.wlan@500181 \
--to=dubowoj@neratec.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
--cc=nledovskikh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).