From: Johannes Berg <johannes@sipsolutions.net>
To: Pavel Roskin <proski@gnu.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: Kernel oops in code added by "cfg80211: allow userspace to control supported rates in scan"
Date: Wed, 20 Jul 2011 00:26:47 +0200 [thread overview]
Message-ID: <1311114408.3872.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4E25FEB3.1030005@gnu.org>
On Tue, 2011-07-19 at 18:01 -0400, Pavel Roskin wrote:
> On 07/19/2011 05:55 PM, Johannes Berg wrote:
> > On Tue, 2011-07-19 at 17:42 -0400, Pavel Roskin wrote:
> >
> >> for (i = 0; i< IEEE80211_NUM_BANDS; i++)
> >> request->rates[i] = (1<< wiphy->bands[i]->n_bitrates) - 1;
> >
> > Ah crap, I didn't pay attention and never tested a single-band card.
> > Below change should fix it.
>
> Tested-by: Pavel Roskin <proski@gnu.org>
>
> The ultimate test - sending via the wireless connection :)
:)
I'll run another test to see if it actually _works_ on single-band cards
and submit it, sorry about that!
johannes
prev parent reply other threads:[~2011-07-19 22:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 21:42 Kernel oops in code added by "cfg80211: allow userspace to control supported rates in scan" Pavel Roskin
2011-07-19 21:55 ` Johannes Berg
2011-07-19 22:01 ` Pavel Roskin
2011-07-19 22:26 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311114408.3872.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox