From: wwguy <wey-yi.w.guy@intel.com>
To: Keith Packard <keithp@keithp.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iwlagn: check for !priv->txq in iwlagn_wait_tx_queue_empty
Date: Mon, 25 Jul 2011 13:59:07 -0700 [thread overview]
Message-ID: <1311627547.13973.2.camel@wwguy-ubuntu> (raw)
In-Reply-To: <yunvcuqunzd.fsf@aiko.keithp.com>
On Mon, 2011-07-25 at 13:03 -0700, Keith Packard wrote:
> On Mon, 25 Jul 2011 12:21:55 -0700, "Guy, Wey-Yi" <wey-yi.w.guy@intel.com> wrote:
>
> > but why you need it?, "start device" call will fail if can not allocate
> > priv->txq
>
> The device is down, so start_device was never called. At least, that's
> my assumption -- I've got the wireless device 'disabled' in
> NetworkManager.
>
the iwlagn_wait_tx_queue_empty() function only can be call from either
"flush" operation or from debugfs. I agree it is a problem if call from
debugfs. did you actually see the problem when it is not from debugfs().
there is a recent patch in mac80211 to make sure do not call "flush" is
not needed.
Thanks
Wey
next prev parent reply other threads:[~2011-07-25 21:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 19:38 [PATCH] iwlagn: check for !priv->txq in iwlagn_wait_tx_queue_empty Keith Packard
2011-07-25 19:21 ` Guy, Wey-Yi
2011-07-25 20:03 ` Keith Packard
2011-07-25 20:59 ` wwguy [this message]
2011-07-26 6:45 ` Keith Packard
2011-07-26 13:22 ` Guy, Wey-Yi
2011-07-30 0:52 ` Keith Packard
2011-07-25 19:36 ` wwguy
2011-07-25 19:43 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311627547.13973.2.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=ilw@linux.intel.com \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).