From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 4/6] mac80211: update mesh peering frame format
Date: Mon, 08 Aug 2011 21:10:30 +0200 [thread overview]
Message-ID: <1312830630.4372.40.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAG6hwVN4i5Yh_ea0j3kvPyznUuZmfxog2OzK1Y74eveU2kR6Dg@mail.gmail.com> (sfid-20110808_204803_654787_1BCECA1A)
On Mon, 2011-08-08 at 11:47 -0700, Thomas Pedersen wrote:
> >> + case WLAN_CATEGORY_SELF_PROTECTED:
> >> + switch (mgmt->u.action.u.self_prot.action_code) {
> >> + case WLAN_SP_MESH_PEERING_OPEN:
> >> + case WLAN_SP_MESH_PEERING_CLOSE:
> >> + case WLAN_SP_MESH_PEERING_CONFIRM:
> >> + if (!ieee80211_vif_is_mesh(&sdata->vif))
> >> + goto invalid;
> >> + if (sdata->u.mesh.security != IEEE80211_MESH_SEC_NONE)
> >> + /* userspace handles this frame */
> >
> > Will this compile in the CONFIG_MAC80211_MESH=n case? It seems like it
> > might not? Do you routinely test that?
> >
>
> Yes. The CONFIG_MAC80211_MESH check around the ieee80211_if_mesh was
> removed in c80d545da3f7c0e534ccd4a780f322f80a92cff1
I mean the "sdata->u.mesh.security" dereference. I know vif_is_mesh() is
always available, but I thought u.mesh wasn't?
johannes
next prev parent reply other threads:[~2011-08-08 19:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 23:59 [PATCH 0/6] update mesh frame formats Thomas Pedersen
2011-07-25 23:59 ` [PATCH 1/6] mac80211: fix mesh beacon format Thomas Pedersen
2011-08-08 13:21 ` Johannes Berg
2011-07-25 23:59 ` [PATCH 2/6] ieee80211: introduce Self Protected Action codes Thomas Pedersen
2011-07-25 23:59 ` [PATCH 3/6] mac80211: update mesh peering frame codes Thomas Pedersen
2011-07-25 23:59 ` [PATCH 4/6] mac80211: update mesh peering frame format Thomas Pedersen
2011-08-08 13:24 ` Johannes Berg
2011-08-08 18:47 ` Thomas Pedersen
2011-08-08 19:10 ` Johannes Berg [this message]
2011-08-08 19:15 ` Thomas Pedersen
2011-07-25 23:59 ` [PATCH 5/6] ieee80211: add mesh action codes Thomas Pedersen
2011-07-25 23:59 ` [PATCH 6/6] mac80211: update mesh path selection frame format Thomas Pedersen
2011-07-29 0:37 ` [PATCH v2] " Thomas Pedersen
-- strict thread matches above, loose matches on Subject: below --
2011-08-09 19:50 [PATCH 0/6] mac80211: mesh frame formats Thomas Pedersen
2011-08-09 19:50 ` [PATCH 4/6] mac80211: update mesh peering frame format Thomas Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312830630.4372.40.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).