From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211: fix resuming when device is gone
Date: Tue, 09 Aug 2011 13:46:42 +0200 [thread overview]
Message-ID: <1312890402.4109.24.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1312890325.4109.23.camel@jlt3.sipsolutions.net> (sfid-20110809_134530_731807_FBE4BB9A)
On Tue, 2011-08-09 at 13:45 +0200, Johannes Berg wrote:
> On Tue, 2011-08-09 at 13:43 +0200, Johannes Berg wrote:
>
> > > Yes, but __ieee80211_resume() calls directly ieee80211_reconfig().
> >
> > Sure. Just trying to make sure I understand where it's coming from. So
> > wiphy_unregister() is still running, before device_del(), but then we
> > get the resume from the core...
> >
> > Shouldn't we implement this logic you just did in cfg80211 instead?
>
> Although I guess until wiphy_unregister() returns, drivers must still
> expect callbacks, which clearly mac80211 didn't handle correctly here
> with the timer...
Actually...
Doesn't that just mean we need to reorder the code in _free_hw()? If we
do the timer stuff after wiphy_unregister(), we should be OK, and
prevent other, similar problems in the future too.
johannes
next prev parent reply other threads:[~2011-08-09 11:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 14:19 [RFC] mac80211: fix resuming when device is gone Stanislaw Gruszka
2011-08-08 15:58 ` Johannes Berg
2011-08-09 9:23 ` Stanislaw Gruszka
2011-08-09 9:28 ` Johannes Berg
2011-08-09 9:29 ` Johannes Berg
2011-08-09 9:43 ` Stanislaw Gruszka
2011-08-09 9:39 ` Stanislaw Gruszka
2011-08-09 9:45 ` Johannes Berg
2011-08-09 11:36 ` Stanislaw Gruszka
2011-08-09 11:43 ` Johannes Berg
2011-08-09 11:45 ` Johannes Berg
2011-08-09 11:46 ` Johannes Berg [this message]
2011-08-09 11:47 ` Johannes Berg
2011-08-09 15:30 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312890402.4109.24.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).