From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: Eliad Peller <eliad@wizery.com>, linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/2] mac80211: config hw when going back on-channel
Date: Tue, 09 Aug 2011 15:28:48 +0200 [thread overview]
Message-ID: <1312896528.4109.43.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4E4135C4.4020607@candelatech.com>
On Tue, 2011-08-09 at 06:27 -0700, Ben Greear wrote:
> On 08/09/2011 05:14 AM, Johannes Berg wrote:
> > On Mon, 2011-07-25 at 10:18 -0700, Ben Greear wrote:
> >> On 07/25/2011 08:29 AM, Eliad Peller wrote:
> >>> The hw is currently not configured when going
> >>> back on-channel.
> >>
> >> I am less sure about this patch. With the existing code,
> >> I think it should catch going from on channel to off
> >> and do the hw config properly.
> >>
> >> With your change it will also reconfig the hardware, but it will
> >> reconfig even if we were already on-channel (if, for instance,
> >> local->tmp_channel is oper-channel), right?
> >
> > I think even if we're already on the same channel, we might still have
> > the off-channel flag (IEEE80211_CONF_OFFCHANNEL) set? So the patch might
> > still be needed to clear that?
>
> Well, maybe so, but if we are not off-channel and still have the off-channel
> flag set, that would seem to be another bug.
Hm, true. Not sure about this then.
johannes
next prev parent reply other threads:[~2011-08-09 13:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 15:29 [RFC 0/2] mac80211 offchannel fixes Eliad Peller
2011-07-25 15:29 ` [RFC 1/2] mac80211: fix remain_off_channel regression Eliad Peller
2011-07-25 17:13 ` Ben Greear
2011-08-09 12:13 ` Johannes Berg
2011-08-09 12:48 ` Eliad Peller
2011-08-09 12:55 ` Johannes Berg
2011-10-19 18:03 ` Ben Greear
2011-10-20 16:47 ` Eliad Peller
2011-07-25 15:29 ` [RFC 2/2] mac80211: config hw when going back on-channel Eliad Peller
2011-07-25 17:18 ` Ben Greear
2011-07-25 19:16 ` Eliad Peller
2011-07-25 19:56 ` Ben Greear
2011-07-25 20:07 ` Eliad Peller
2011-07-26 4:39 ` Ben Greear
2011-07-26 5:48 ` Eliad Peller
2011-08-09 12:14 ` Johannes Berg
2011-08-09 13:27 ` Ben Greear
2011-08-09 13:28 ` Johannes Berg [this message]
2011-08-09 13:33 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312896528.4109.43.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eliad@wizery.com \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).