linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 1/6] mac80211: fix mesh beacon format
Date: Wed, 10 Aug 2011 15:37:04 +0200	[thread overview]
Message-ID: <1312983424.4325.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1312919418-32196-2-git-send-email-thomas@cozybit.com> (sfid-20110809_215155_359071_854103B9)

On Tue, 2011-08-09 at 12:50 -0700, Thomas Pedersen wrote:

> -		mgmt->u.beacon.capab_info = 0x0; /* 0x0 for MPs */
> +		mgmt->u.beacon.capab_info |= sdata->u.mesh.security
> +					     ? WLAN_CAPABILITY_PRIVACY : 0;

This should, I believe, warn if you run with sparse (make C=1
M=net/mac80211 or your favourite invocation) -- there's an endian error
here.

johannes


  reply	other threads:[~2011-08-10 13:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 19:50 [PATCH 0/6] mac80211: mesh frame formats Thomas Pedersen
2011-08-09 19:50 ` [PATCH 1/6] mac80211: fix mesh beacon format Thomas Pedersen
2011-08-10 13:37   ` Johannes Berg [this message]
2011-08-10 18:20     ` Thomas Pedersen
2011-08-09 19:50 ` [PATCH 2/6] ieee80211: introduce Self Protected Action codes Thomas Pedersen
2011-08-09 19:50 ` [PATCH 3/6] mac80211: update mesh peering frame codes Thomas Pedersen
2011-08-09 19:50 ` [PATCH 4/6] mac80211: update mesh peering frame format Thomas Pedersen
2011-08-09 19:50 ` [PATCH 5/6] ieee80211: add mesh action codes Thomas Pedersen
2011-08-09 19:50 ` [PATCH 6/6] mac80211: update mesh path selection frame format Thomas Pedersen
  -- strict thread matches above, loose matches on Subject: below --
2011-07-25 23:59 [PATCH 0/6] update mesh frame formats Thomas Pedersen
2011-07-25 23:59 ` [PATCH 1/6] mac80211: fix mesh beacon format Thomas Pedersen
2011-08-08 13:21   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312983424.4325.0.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=thomas@cozybit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).