From: Luciano Coelho <coelho@ti.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, Ido Yariv <ido@wizery.com>
Subject: Re: [PATCH 1/2] wl12xx: Remove obsolete testmode NVS push command
Date: Thu, 11 Aug 2011 08:57:14 +0300 [thread overview]
Message-ID: <1313042234.2407.758.camel@cumari> (raw)
In-Reply-To: <1312269858-30434-1-git-send-email-ido@wizery.com>
On Tue, 2011-08-02 at 10:24 +0300, Ido Yariv wrote:
> The testmode NVS push command is no longer in use. In addition, it has
> several implementation issues that prevent it from working correctly:
>
> 1. wl1271_tm_cmd_configure relies on wl->chip.id being set. However,
> since the device was not necessarily booted by the time the function
> is called, wl->chip.id will be initialized to 0.
> 2. The NVS file is fetched by calling request_firmware() before it is
> possible to push an NVS file.
> 3. The maximum allowed size of nl binary payloads is not sufficient for
> pushing NVS files.
> 4. Pushing 128x NVS files will always fail due to a bug in the
> validation code.
> 5. In case the pushed NVS file is found invalid, the mutex will be kept
> locked and the nvs member will become a dangling pointer.
>
> Since this feature is not being used, remove it completely instead of
> fixing it.
>
> Signed-off-by: Ido Yariv <ido@wizery.com>
> ---
Acked-by: Luciano Coelho <coelho@ti.com>
John, could you please take these two patches into 3.1?
The first one is removing an obsolete feature that was badly broken
(causing security risks) and the second one is a power management bug
fix, without which suspend doesn't work properly with the wl12xx driver.
Thanks!
--
Cheers,
Luca.
prev parent reply other threads:[~2011-08-11 5:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 7:24 [PATCH 1/2] wl12xx: Remove obsolete testmode NVS push command Ido Yariv
2011-08-02 7:24 ` [PATCH 2/2] wl12xx: Fix validation of pm_runtime_get_sync return value Ido Yariv
2011-08-11 5:57 ` Luciano Coelho
2011-08-11 5:57 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313042234.2407.758.camel@cumari \
--to=coelho@ti.com \
--cc=ido@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox