From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga09.intel.com ([134.134.136.24]:23745 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754015Ab1HOO0v (ORCPT ); Mon, 15 Aug 2011 10:26:51 -0400 Subject: Re: [PATCH 05/60] iwlagn: introduce struct iwl-shared - known by all layers From: "Guy, Wey-Yi" To: Stanislaw Gruszka Cc: "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , "Grumbach, Emmanuel" In-Reply-To: <20110815142144.GA15718@redhat.com> References: <1313257116-2697-1-git-send-email-wey-yi.w.guy@intel.com> <1313257116-2697-6-git-send-email-wey-yi.w.guy@intel.com> <20110815081010.GA3317@redhat.com> <20110815084355.GB3317@redhat.com> <1313414020.15170.32.camel@wwguy-huron> <20110815142144.GA15718@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 15 Aug 2011 06:46:45 -0700 Message-ID: <1313416005.15170.35.camel@wwguy-huron> (sfid-20110815_162704_290540_622EA1EA) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2011-08-15 at 07:21 -0700, Stanislaw Gruszka wrote: > On Mon, Aug 15, 2011 at 06:13:39AM -0700, Guy, Wey-Yi wrote: > > now we are working on separate iwlagn driver into two layers (upper and > > lower), the lower layer contains both bus and transport sub-layer which > > is hw dependent, and the upper layer should be bus/hw independent. by > > doing so, the single driver can handle different bus and different core > > architecture. Having the share data structure (priv->shrd->foo) between > > two layers is for that reason (loosely couple). > > You did not explained reason for introducing iwl_shared structure, > actually you confirmed it is useless. You should simply share iwl_priv > on any layer you have. > > Stanislaw It is not true, I mean "boring" but not "useless", it does not make sense share all the priv with lower layer. think about I also mention different core architecture, that mean we can have different upper layer which has different priv; but shrd is always common to all different upper layer to share with lower layer. Wey