* [patch -next] libertas: handle mesh networks in lbs_iface_active()
@ 2011-08-15 11:25 Dan Carpenter
2011-08-15 22:52 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-08-15 11:25 UTC (permalink / raw)
To: Dan Williams, Daniel Drake
Cc: John W. Linville, open list:MARVELL LIBERTAS...,
open list:NETWORKING [WIREL..., kernel-janitors
There was an extra semicolon so the if condition wasn't used. We
checked "priv->dev" twice instead of "priv->mesh_dev".
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Compile tested only.
diff --git a/drivers/net/wireless/libertas/dev.h b/drivers/net/wireless/libertas/dev.h
index 8148389..b9ff0dc 100644
--- a/drivers/net/wireless/libertas/dev.h
+++ b/drivers/net/wireless/libertas/dev.h
@@ -190,8 +190,8 @@ static inline int lbs_iface_active(struct lbs_private *priv)
int r;
r = netif_running(priv->dev);
- if (priv->mesh_dev);
- r |= netif_running(priv->dev);
+ if (priv->mesh_dev)
+ r |= netif_running(priv->mesh_dev);
return r;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch -next] libertas: handle mesh networks in lbs_iface_active()
2011-08-15 11:25 [patch -next] libertas: handle mesh networks in lbs_iface_active() Dan Carpenter
@ 2011-08-15 22:52 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2011-08-15 22:52 UTC (permalink / raw)
To: Dan Carpenter
Cc: Daniel Drake, John W. Linville, open list:MARVELL LIBERTAS...,
open list:NETWORKING [WIREL..., kernel-janitors
On Mon, 2011-08-15 at 14:25 +0300, Dan Carpenter wrote:
> There was an extra semicolon so the if condition wasn't used. We
> checked "priv->dev" twice instead of "priv->mesh_dev".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dan Williams <dcbw@redhat.com>
> ---
> Compile tested only.
>
> diff --git a/drivers/net/wireless/libertas/dev.h b/drivers/net/wireless/libertas/dev.h
> index 8148389..b9ff0dc 100644
> --- a/drivers/net/wireless/libertas/dev.h
> +++ b/drivers/net/wireless/libertas/dev.h
> @@ -190,8 +190,8 @@ static inline int lbs_iface_active(struct lbs_private *priv)
> int r;
>
> r = netif_running(priv->dev);
> - if (priv->mesh_dev);
> - r |= netif_running(priv->dev);
> + if (priv->mesh_dev)
> + r |= netif_running(priv->mesh_dev);
>
> return r;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-15 22:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-15 11:25 [patch -next] libertas: handle mesh networks in lbs_iface_active() Dan Carpenter
2011-08-15 22:52 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).