From: Luciano Coelho <coelho@ti.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Shahar Levi <shahar_levi@ti.com>,
"John W. Linville" <linville@tuxdriver.com>,
"open list:WL1271 WIRELESS D..." <linux-wireless@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] wl12xx: fix recent change to wl1271_tm_cmd_nvs_push()
Date: Wed, 24 Aug 2011 17:18:41 +0300 [thread overview]
Message-ID: <1314195521.2296.204.camel@cumari> (raw)
In-Reply-To: <20110824113139.GE5975@shale.localdomain>
Hi Dan,
On Wed, 2011-08-24 at 14:31 +0300, Dan Carpenter wrote:
> bc765bf3b9a "wl12xx: 1281/1283 support - Loading FW & NVS" had two
> problems. The condition was written so that it failed if "len" was
> not equal to sizeof(struct wl1271_nvs_file). Also we need to release
> the locks on these new error paths.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Thanks for your patch. But we have just removed this function, since
the implementation was broken and the feature is not really used
anymore.
The patch that removes this function entirely is already queued for
inclusion on the 3.1-rc series:
http://git.kernel.org/?p=linux/kernel/git/linville/wireless.git;a=commit;h=80900d0140a7648587982c8f299830e900e49165
--
Cheers,
Luca.
prev parent reply other threads:[~2011-08-24 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 11:31 [patch -next] wl12xx: fix recent change to wl1271_tm_cmd_nvs_push() Dan Carpenter
2011-08-24 14:18 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314195521.2296.204.camel@cumari \
--to=coelho@ti.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=shahar_levi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox