From: Joe Perches <joe@perches.com>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Amitkumar Karwar <akarwar@marvell.com>,
Kiran Divekar <dkiran@marvell.com>,
Yogesh Powar <yogeshp@marvell.com>,
Frank Huang <frankh@marvell.com>, Walter Harms <wharms@bfs.de>
Subject: Re: [PATCH] mwifiex: replace kmalloc & memcpy sequences with kmemdup
Date: Wed, 24 Aug 2011 21:19:16 -0700 [thread overview]
Message-ID: <1314245956.15882.30.camel@Joe-Laptop> (raw)
In-Reply-To: <1314244350-13347-1-git-send-email-bzhao@marvell.com>
On Wed, 2011-08-24 at 20:52 -0700, Bing Zhao wrote:
> Sequences of kmalloc/kzalloc and memcpy are replaced with
> kmemdups.
> diff --git a/drivers/net/wireless/mwifiex/join.c b/drivers/net/wireless/mwifiex/join.c
[]
> - tmp = kmalloc(rate1_size, GFP_KERNEL);
> + tmp = kmemdup(rate1, rate1_size, GFP_KERNEL);
> if (!tmp) {
> - dev_err(priv->adapter->dev, "failed to alloc tmp buf\n");
> + dev_err(priv->adapter->dev, "failed to duplicate rate buf\n");
I wouldn't modify any OOM message.
These _are_ allocs failures.
[all the others removed]
next prev parent reply other threads:[~2011-08-25 4:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 3:52 [PATCH] mwifiex: replace kmalloc & memcpy sequences with kmemdup Bing Zhao
2011-08-25 4:19 ` Joe Perches [this message]
2011-08-25 19:39 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314245956.15882.30.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=dkiran@marvell.com \
--cc=frankh@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wharms@bfs.de \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox