From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Carpenter <error27@gmail.com>
Cc: emmanuel.grumbach@intel.com, Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
"open list:INTEL WIRELESS WI..." <linux-wireless@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next 1/2] iwlwifi: fix double assign in iwl_start_tx_ba_trans_ready()
Date: Wed, 31 Aug 2011 08:41:27 +0200 [thread overview]
Message-ID: <1314772887.4161.17.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20110831063742.GC3705@shale.localdomain> (sfid-20110831_084010_132544_82772E48)
On Wed, 2011-08-31 at 09:37 +0300, Dan Carpenter wrote:
> "vif" is assigned twice. We can remove the first one.
>
> This silences a Smatch warning that "ctx" could be one step past the
> end of the priv->contexts[] array.
Good catch.
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c
> index 20dd1a5..72b9203 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-core.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-core.c
> @@ -1842,7 +1842,7 @@ void iwl_start_tx_ba_trans_ready(struct iwl_priv *priv,
> enum iwl_rxon_context_id ctx,
> u8 sta_id, u8 tid)
> {
> - struct ieee80211_vif *vif = priv->contexts[ctx].vif;
> + struct ieee80211_vif *vif;
> u8 *addr = priv->stations[sta_id].sta.sta.addr;
>
> if (ctx == NUM_IWL_RXON_CTX)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2011-08-31 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 6:37 [patch -next 1/2] iwlwifi: fix double assign in iwl_start_tx_ba_trans_ready() Dan Carpenter
2011-08-31 6:41 ` Johannes Berg [this message]
2011-08-31 9:34 ` Guy, Wey-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314772887.4161.17.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=emmanuel.grumbach@intel.com \
--cc=error27@gmail.com \
--cc=ilw@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).