* [patch -next 2/2] iwlwifi: signedness bug in iwl_trans_pcie_tx_agg_alloc()
@ 2011-08-31 6:38 Dan Carpenter
2011-08-31 9:35 ` Guy, Wey-Yi
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-08-31 6:38 UTC (permalink / raw)
To: emmanuel.grumbach
Cc: Wey-Yi Guy, Intel Linux Wireless, John W. Linville,
open list:INTEL WIRELESS WI..., kernel-janitors
unsigned shorts and unsigned chars are never == -1.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c b/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c
index 5dd6a6d..ea6a0bc 100644
--- a/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c
+++ b/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c
@@ -535,7 +535,7 @@ int iwl_trans_pcie_tx_agg_alloc(struct iwl_trans *trans,
struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans);
struct iwl_tid_data *tid_data;
unsigned long flags;
- u16 txq_id;
+ int txq_id;
struct iwl_priv *priv = priv(trans);
txq_id = iwlagn_txq_ctx_activate_free(trans);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch -next 2/2] iwlwifi: signedness bug in iwl_trans_pcie_tx_agg_alloc()
2011-08-31 6:38 [patch -next 2/2] iwlwifi: signedness bug in iwl_trans_pcie_tx_agg_alloc() Dan Carpenter
@ 2011-08-31 9:35 ` Guy, Wey-Yi
0 siblings, 0 replies; 2+ messages in thread
From: Guy, Wey-Yi @ 2011-08-31 9:35 UTC (permalink / raw)
To: Dan Carpenter
Cc: Grumbach, Emmanuel, Intel Linux Wireless, John W. Linville,
open list:INTEL WIRELESS WI..., kernel-janitors@vger.kernel.org
On Tue, 2011-08-30 at 23:38 -0700, Dan Carpenter wrote:
> unsigned shorts and unsigned chars are never == -1.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c b/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c
> index 5dd6a6d..ea6a0bc 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c
> @@ -535,7 +535,7 @@ int iwl_trans_pcie_tx_agg_alloc(struct iwl_trans *trans,
> struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans);
> struct iwl_tid_data *tid_data;
> unsigned long flags;
> - u16 txq_id;
> + int txq_id;
> struct iwl_priv *priv = priv(trans);
>
> txq_id = iwlagn_txq_ctx_activate_free(trans);
True
Wey
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-31 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-31 6:38 [patch -next 2/2] iwlwifi: signedness bug in iwl_trans_pcie_tx_agg_alloc() Dan Carpenter
2011-08-31 9:35 ` Guy, Wey-Yi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).