From: Joe Perches <joe@perches.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH 3/3] b43: LCN-PHY: load TX gain table on init
Date: Sat, 03 Sep 2011 13:21:22 -0700 [thread overview]
Message-ID: <1315081282.1773.19.camel@Joe-Laptop> (raw)
In-Reply-To: <1315076463-11222-4-git-send-email-zajec5@gmail.com>
On Sat, 2011-09-03 at 21:01 +0200, Rafał Miłecki wrote:
> Values and ops were taken from MMIO dump of wl. struct was copied from
> brcmsmac.
[]
> diff --git a/drivers/net/wireless/b43/tables_phy_lcn.c b/drivers/net/wireless/b43/tables_phy_lcn.c
[]
> +const struct b43_lcntab_tx_gain_tbl_entry
> + b43_lcntab_tx_gain_tbl_2ghz_ext_pa_rev0[] = {
128 entries follow...
> + { 0x03, 0x00, 0x1f, 0x0, 0x48 },
[etc]
> + { 0x03, 0x00, 0x01, 0x0, 0x39 },
> +};
> +void b43_phy_lcn_load_tx_gain_tab(struct b43_wldev *dev,
> + const struct b43_lcntab_tx_gain_tbl_entry *gain_table)
Are there multiple gain tables?
> +{
> + u32 i;
> + u32 val;
> +
> + u16 pa_gain = 0x70;
> + if (dev->dev->bus_sprom->boardflags_lo & B43_BFL_FEM)
> + pa_gain = 0x10;
> +
> + for (i = 0; i < 128; i++) {
Can this be a fixed table and ARRAY_SIZE?
next prev parent reply other threads:[~2011-09-03 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 19:01 [PATCH 0/3] Update copyrights, module info, a little LCN improvement Rafał Miłecki
2011-09-03 19:01 ` [PATCH 1/3] b43: drop Copyright for not really copyrightable info Rafał Miłecki
2011-09-03 19:01 ` [PATCH 2/3] b43: add my copyrights and myself as the module author Rafał Miłecki
2011-09-03 19:01 ` [PATCH 3/3] b43: LCN-PHY: load TX gain table on init Rafał Miłecki
2011-09-03 19:40 ` Rafał Miłecki
2011-09-03 20:21 ` Joe Perches [this message]
2011-09-04 6:31 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315081282.1773.19.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox