From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/3] mac80211: unify TIM bit handling
Date: Tue, 06 Sep 2011 14:26:18 +0200 [thread overview]
Message-ID: <1315311978.26306.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20110906121534.491842279@sipsolutions.net> (sfid-20110906_141651_215347_47149ADC)
> +void sta_info_recalc_tim(struct sta_info *sta)
> {
> - __bss_tim_clear(bss, sta->sta.aid);
> + spin_lock_irqsave(&local->sta_lock, flags);
>
> - if (sta->local->ops->set_tim) {
> - sta->local->tim_in_locked_section = true;
> - drv_set_tim(sta->local, &sta->sta, false);
> - sta->local->tim_in_locked_section = false;
> + have_data = test_sta_flags(sta, WLAN_STA_PS_DRIVER_BUF) ||
> + !skb_queue_empty(&sta->tx_filtered) ||
> + !skb_queue_empty(&sta->ps_tx_buf);
I'll move the locking to after the have_data check, it's not needed
around it.
johannes
next prev parent reply other threads:[~2011-09-06 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 12:14 [RFC 0/3] some AP PS buffering rework Johannes Berg
2011-09-06 12:14 ` [RFC 1/3] mac80211: let drivers inform it about per TID buffered frames Johannes Berg
2011-09-06 12:14 ` [RFC 2/3] mac80211: unify TIM bit handling Johannes Berg
2011-09-06 12:26 ` Johannes Berg [this message]
2011-09-06 12:14 ` [RFC 3/3] mac80211: also expire filtered frames Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315311978.26306.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).