From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: John Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCHv2 2/2] mac80211: Tear down BA session on BAR tx failure
Date: Tue, 06 Sep 2011 21:39:44 +0200 [thread overview]
Message-ID: <1315337984.26306.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1313072262-25413-2-git-send-email-helmut.schaa@googlemail.com> (sfid-20110811_161758_327900_A241E512)
> + /*
> + * BAR failed, let's tear down the BA session as a
> + * last resort as some STAs (Intel 5100 on Windows)
> + * can get stuck when the BA window isn't flushed
> + * correctly.
> + */
> + bar = (struct ieee80211_bar *) skb->data;
> + if (!(bar->control & IEEE80211_BAR_CTRL_MULTI_TID)) {
> + tid = (bar->control &
> + IEEE80211_BAR_CTRL_TID_INFO_MASK) >>
> + IEEE80211_BAR_CTRL_TID_INFO_SHIFT;
> + ieee80211_stop_tx_ba_session(&sta->sta, tid);
Meh. Please, everyone, run sparse:
net/mac80211/status.c:276:34: warning: restricted __le16 degrades to integer
net/mac80211/status.c:277:43: warning: restricted __le16 degrades to integer
johannes
prev parent reply other threads:[~2011-09-06 19:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 9:08 [PATCH] mac80211: Tear down BA session on BAR tx failure Helmut Schaa
2011-08-11 10:05 ` Adrian Chadd
2011-08-11 12:58 ` Johannes Berg
2011-08-11 13:25 ` Helmut Schaa
2011-08-11 14:17 ` [PATCH 1/2] wireless: Introduce defines for BAR TID_INFO & MULTI_TID fields Helmut Schaa
2011-08-11 14:17 ` [PATCHv2 2/2] mac80211: Tear down BA session on BAR tx failure Helmut Schaa
2011-09-06 19:39 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315337984.26306.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox