From: wwguy <wey-yi.w.guy@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [FYI] iwlagn: fix command queue timeout
Date: Fri, 09 Sep 2011 07:18:01 -0700 [thread overview]
Message-ID: <1315577881.19667.16.camel@wwguy-ubuntu> (raw)
In-Reply-To: <1315570879.17050.11.camel@jlt3.sipsolutions.net>
On Fri, 2011-09-09 at 05:21 -0700, Johannes Berg wrote:
> On Fri, 2011-09-09 at 14:19 +0200, Johannes Berg wrote:
>
> > Fix this by setting the timestamp when
> > a command completes.
>
> FWIW, I don't think this is a really good fix, I think it should have a
> timer per queue that never fires, and when it fires the queue is stuck
> -- i.e. mod the timer into the future whenever a command/tx frame
> completes and cancel the timer when the queue goes empty (and start it
> if it's pending when we enqueue something)
>
Agree, we need better fix, I saw this happen number of times on my
system which does not have P2P and no traffic. One time even just
loading the iwlagn module; not sure it is the same case.
Thanks
Wey
>
prev parent reply other threads:[~2011-09-09 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 12:14 [FYI] iwlagn: do not use interruptible waits Johannes Berg
2011-09-09 12:19 ` [FYI] iwlagn: fix command queue timeout Johannes Berg
2011-09-09 12:21 ` Johannes Berg
2011-09-09 14:18 ` wwguy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315577881.19667.16.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox