From: Luciano Coelho <coelho@ti.com>
To: Arik Nemtsov <arik@wizery.com>
Cc: Kalle Valo <kvalo@adurom.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/6] wl12xx: AP mode - don't regulate FW blocks for non-active STAs
Date: Wed, 14 Sep 2011 12:56:02 +0300 [thread overview]
Message-ID: <1315994162.2498.88.camel@cumari> (raw)
In-Reply-To: <CA+XVXff93Qhj6URUMzE99j30NVB+4_M_NwsxHKYOxbHwpwE1yg@mail.gmail.com>
On Wed, 2011-09-14 at 12:44 +0300, Arik Nemtsov wrote:
> On Thu, Aug 25, 2011 at 13:05, Kalle Valo <kvalo@adurom.com> wrote:
> > Arik Nemtsov <arik@wizery.com> writes:
> >
> >> + if (!wl1271_is_active_sta(wl, hlid)) {
> >> + WARN_ON(1);
> >> + return;
> >> + }
> >
> > I think this is neater:
> >
> > if (WARN_ON(!wl1271_is_active_sta(wl, hlid))
> > return;
>
> (Sorry for the late response)
>
> It does look nicer. Luca - do you mind changing it before merging?
Done, and thanks for giving me more work to do! Oh, well, I deserved
it. :P
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-09-14 9:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 9:43 [PATCH 1/6] wl12xx: don't indicate up PS-filtered dummy packets Arik Nemtsov
2011-08-25 9:43 ` [PATCH 2/6] wl12xx: AP mode - don't regulate FW blocks for non-active STAs Arik Nemtsov
2011-08-25 10:05 ` Kalle Valo
2011-09-14 9:44 ` Arik Nemtsov
2011-09-14 9:56 ` Luciano Coelho [this message]
2011-08-25 9:43 ` [PATCH 3/6] wl12xx: support up to 8 stations in AP-mode Arik Nemtsov
2011-08-25 9:43 ` [PATCH 4/6] wl12xx: don't regulate links when a single STA is connected Arik Nemtsov
2011-08-25 9:43 ` [PATCH 5/6] wl12xx: AP mode - enable the BA constraint event from the FW Arik Nemtsov
2011-08-25 9:43 ` [PATCH 6/6] wl12xx: AP mode - clean BA and queue state in tx_reset Arik Nemtsov
2011-09-14 9:56 ` [PATCH 1/6] wl12xx: don't indicate up PS-filtered dummy packets Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315994162.2498.88.camel@cumari \
--to=coelho@ti.com \
--cc=arik@wizery.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).