From: Johannes Berg <johannes@sipsolutions.net>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] wireless: Fix rate mask for scan request
Date: Thu, 15 Sep 2011 11:19:18 +0200 [thread overview]
Message-ID: <1316078358.3992.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1316078089-7221-1-git-send-email-rmanohar@qca.qualcomm.com>
On Thu, 2011-09-15 at 14:44 +0530, Rajkumar Manoharan wrote:
> The scan request received from cfg80211_connect do not
> have proper rate mast. So the probe request sent on each
> channel do not have proper the supported rates ie.
>
> Cc: stable@kernel.org
> Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
> ---
> net/wireless/sme.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
> index b7b6ff8..8b6ef34 100644
> --- a/net/wireless/sme.c
> +++ b/net/wireless/sme.c
> @@ -118,6 +118,7 @@ static int cfg80211_conn_scan(struct wireless_dev *wdev)
> i++, j++)
> request->channels[i] =
> &wdev->wiphy->bands[band]->channels[j];
> + request->rates[band] = (u32) -1;
Please use
(1 << wiphy->bands[band]->n_bitrates) - 1;
so we don't have invalid bits set.
Also, CC stable doesn't work that way -- you don't CC them, you just
write into it "Cc: stable@kernel.org". This makes them pick out the
patch later once it got applied.
johannes
next prev parent reply other threads:[~2011-09-15 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 9:14 [RFC] wireless: Fix rate mask for scan request Rajkumar Manoharan
2011-09-15 9:19 ` Johannes Berg [this message]
2011-09-15 9:19 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316078358.3992.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox