From: Joe Perches <joe@perches.com>
To: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Subject: [PATCH] iwlagn: Convert kzalloc to kcalloc
Date: Thu, 15 Sep 2011 12:47:26 -0700 [thread overview]
Message-ID: <1316116047.11236.8.camel@Joe-Laptop> (raw)
In-Reply-To: <1316112830.19293.4.camel@wwguy-huron>
Convert kzalloc to kcalloc, coalesce multiple lines too.
Signed-off-by: Joe Perches <joe@perches.com>
---
On Thu, 2011-09-15 at 11:53 -0700, Guy, Wey-Yi wrote:
> On Thu, 2011-09-15 at 12:37 -0700, Joe Perches wrote:
> > kcalloc would be even prettier...
> agree, would you mind submit a patch to changes it
Just converted your original patch inline.
drivers/net/wireless/iwlwifi/iwl-trans.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans.c b/drivers/net/wireless/iwlwifi/iwl-trans.c
index d4f6281..498e006 100644
--- a/drivers/net/wireless/iwlwifi/iwl-trans.c
+++ b/drivers/net/wireless/iwlwifi/iwl-trans.c
@@ -308,10 +308,8 @@ static int iwl_trans_txq_alloc(struct iwl_trans *trans,
txq->q.n_window = slots_num;
- txq->meta = kzalloc(sizeof(txq->meta[0]) * slots_num,
- GFP_KERNEL);
- txq->cmd = kzalloc(sizeof(txq->cmd[0]) * slots_num,
- GFP_KERNEL);
+ txq->meta = kcalloc(slots_num, sizeof(txq->meta[0]), GFP_KERNEL);
+ txq->cmd = kcalloc(slots_num, sizeof(txq->cmd[0]), GFP_KERNEL);
if (!txq->meta || !txq->cmd)
goto error;
next prev parent reply other threads:[~2011-09-15 19:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 18:46 [PATCH 00/27] update for 3.2 Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 01/27] iwlagn: warn about buggy fw that doesn't set SEQ_RX_FRAME Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 02/27] iwlagn: unmap cmd queue's tfds as BIDI Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 03/27] iwlagn: free the Tx cmd when a non empty Tx queue is freed Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 04/27] iwlagn: move iwl_stop / wake_queue to the upper layer Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 05/27] iwlagn: use enum iwl_rxon_context_id instead of u8 Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 06/27] iwlagn: document the bus layer API Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 07/27] iwlagn: add documentation to the transport layer Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 08/27] iwlagn: beautify the code - remove uneeded line break Wey-Yi Guy
2011-09-15 19:37 ` Joe Perches
2011-09-15 18:53 ` Guy, Wey-Yi
2011-09-15 19:47 ` Joe Perches [this message]
2011-09-15 22:54 ` [PATCH] iwlagn: Convert kzalloc to kcalloc wwguy
2011-09-15 23:14 ` Joe Perches
2011-09-15 23:18 ` Luis R. Rodriguez
2011-09-15 23:21 ` Joe Perches
2011-09-15 23:21 ` Luis R. Rodriguez
2011-09-15 18:46 ` [PATCH 09/27] iwlagn: New SKU for 6005 SFF Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 10/27] iwlagn: fix modinfo display for 135 ucode Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 11/27] iwlagn: simplify chain_noise_num_beacons indirection Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 12/27] iwlagn: replace beacon_time_fsf_bits variable with #define Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 13/27] iwlagn: provide data after WARN_ON Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 14/27] iwlagn: merge eeprom access into single file Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 15/27] iwlagn: move PCI-E transport files Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 16/27] iwlagn: generically provide iwl_trans_send_cmd_pdu Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 17/27] iwlagn: Makefile whitespace cleanup Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 18/27] iwlagn: clean up PM code Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 19/27] iwlagn: rename iwl-pci.h to iwl-cfg.h Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 20/27] iwlagn: remove unused function declarations Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 21/27] iwlagn: move sysfs files to debugfs Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 22/27] iwlagn: remove drvdata support from bus layer Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 23/27] iwlagn: add support for v2 of temperature offset calibration Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 24/27] iwlagn: use iwl_eeprom_calib_hdr structure Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 25/27] iwlagn: do not use interruptible waits Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 26/27] iwlagn: fix stack corruption for temperature offset v2 Wey-Yi Guy
2011-09-15 18:46 ` [PATCH 27/27] iwlagn: signedness bug Wey-Yi Guy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316116047.11236.8.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).