From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: linux-wireless@vger.kernel.org, Kalyan C Gaddam <chakkal@iit.edu>
Subject: Re: [RFC 2/5] mac80211: handle TDLS high-level commands and frames
Date: Fri, 16 Sep 2011 14:59:45 +0200 [thread overview]
Message-ID: <1316177985.4130.29.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1316082334-7664-3-git-send-email-arik@wizery.com> (sfid-20110915_122551_202876_5B22F090)
On Thu, 2011-09-15 at 13:25 +0300, Arik Nemtsov wrote:
> + case NL80211_TDLS_ENABLE_LINK:
> + rcu_read_lock();
> + sta = sta_info_get(sdata, peer);
> + if (sta) {
> + set_sta_flags(sta, WLAN_STA_AUTHORIZED);
> + sta->tdls_link_enabled = true;
> + }
> + rcu_read_unlock();
> + break;
This seems to require the station already having been added, but
couldn't this create the data race you were worried about? Could you not
simply just create the station once it is authorized?
> + case NL80211_TDLS_DISABLE_LINK:
> + rcu_read_lock();
> + sta = sta_info_get(sdata, peer);
> + if (sta) {
> + sta->tdls_link_enabled = false;
> + sta_info_destroy_addr(sdata, peer);
> + }
> + rcu_read_unlock();
> + break;
Isn't that equivalent to just deleting the station?
johannes
next prev parent reply other threads:[~2011-09-16 12:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 10:25 [RFC 0/5] TDLS support for nl80211/mac80211 drivers Arik Nemtsov
2011-09-15 10:25 ` [RFC 1/5] nl80211: support sending TDLS commands/frames Arik Nemtsov
2011-09-21 11:54 ` Johannes Berg
2011-09-22 0:36 ` Kalyan Chakravarthy
2011-09-22 7:55 ` Johannes Berg
2011-09-22 7:44 ` Arik Nemtsov
2011-09-15 10:25 ` [RFC 2/5] mac80211: handle TDLS high-level commands and frames Arik Nemtsov
2011-09-16 12:59 ` Johannes Berg [this message]
2011-09-16 16:57 ` Arik Nemtsov
2011-09-21 12:05 ` Johannes Berg
2011-09-22 7:34 ` Arik Nemtsov
2011-09-22 11:40 ` Johannes Berg
2011-09-22 18:38 ` Arik Nemtsov
2011-09-15 10:25 ` [RFC 3/5] nl80211/mac80211: allow adding TDLS peers as stations Arik Nemtsov
2011-09-21 12:06 ` Johannes Berg
2011-09-22 7:37 ` Arik Nemtsov
2011-09-15 10:25 ` [RFC 4/5] mac80211: add a HW flag for TDLS support Arik Nemtsov
2011-09-19 19:52 ` Arik Nemtsov
2011-09-21 12:06 ` Johannes Berg
2011-09-22 7:39 ` Arik Nemtsov
2011-09-15 10:25 ` [RFC 5/5] mac80211: send data directly to TDLS peers Arik Nemtsov
2011-09-16 13:03 ` Johannes Berg
2011-09-16 17:01 ` Arik Nemtsov
2011-09-21 12:07 ` Johannes Berg
2011-09-22 7:42 ` Arik Nemtsov
2011-09-16 12:58 ` [RFC 0/5] TDLS support for nl80211/mac80211 drivers Johannes Berg
2011-09-16 16:48 ` Arik Nemtsov
2011-09-19 12:20 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316177985.4130.29.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=chakkal@iit.edu \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).