From: Luciano Coelho <coelho@ti.com>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] wl12xx: add dynamic_ps_timeout debugfs entry
Date: Mon, 19 Sep 2011 08:11:37 +0300 [thread overview]
Message-ID: <1316409097.2157.11.camel@cumari> (raw)
In-Reply-To: <1316347759-22030-1-git-send-email-eliad@wizery.com>
On Sun, 2011-09-18 at 15:09 +0300, Eliad Peller wrote:
> Add debugfs entry to control the dynamic ps default
> timeout (value in ms).
>
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---
Another thing, how are you planning to use this debugfs entry? Just for
testing, right? And if yes, I think it shouldn't, in the end, be a
debugfs entry, but something that the driver figures out by itself. We
really cannot have non-debugging values settable in debugfs.
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-09-19 5:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-18 12:09 [PATCH 1/2] wl12xx: add dynamic_ps_timeout debugfs entry Eliad Peller
2011-09-18 12:09 ` [PATCH 2/2] wl12xx: handle CHANGE_AUTO_MODE_TIMEOUT_EVENT_ID Eliad Peller
2011-09-19 5:21 ` Luciano Coelho
2011-09-19 7:07 ` Eliad Peller
2011-09-19 5:07 ` [PATCH 1/2] wl12xx: add dynamic_ps_timeout debugfs entry Luciano Coelho
2011-09-19 5:11 ` Luciano Coelho [this message]
2011-09-22 5:33 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316409097.2157.11.camel@cumari \
--to=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox