Re: [PATCH] mac80211: add ieee80211_set_dyn_ps_timeout()

[Johannes Berg <johannes@sipsolutions.net>]

On Tue, 2011-09-20 at 15:05 +0300, Eliad Peller wrote:

> > It'd be interesting to see if we can just treat this as a "minimum awake
> > time", kinda like going back to the range I thought about earlier.
> >
> do you mean something like:
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 4274e94..57695e3 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -702,11 +702,12 @@ void ieee80211_recalc_ps(struct ieee80211_local
> *local, s32 latency)
>                         if (latency > (1900 * USEC_PER_MSEC) &&
>                             latency != (2000 * USEC_PER_SEC))
>                                 timeout = 0;
> -                       else if (local->dynamic_ps_driver_timeout >= 0)
> -                               timeout = local->dynamic_ps_driver_timeout;
>                         else
>                                 timeout = 100;
>                 }
> +               if (timeout && local->dynamic_ps_driver_timeout > timeout)
> +                       timeout = local->dynamic_ps_driver_timeout;
> +
>                 local->dynamic_ps_user_timeout = timeout;
>                 if (!local->disable_dynamic_ps)
>                         conf->dynamic_ps_timeout =
> 
> ?
> 
> i don't find it much different.

I did mean something like that, yes, but I was thinking we actually
calculate the timeout based on latency requirements :)

johannes