From: wwguy <wey-yi.w.guy@intel.com>
To: Daniel Halperin <dhalperi@cs.washington.edu>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH 7/8] iwlagn: pending frames musn't be incremented if agg is on
Date: Tue, 20 Sep 2011 17:35:15 -0700 [thread overview]
Message-ID: <1316565315.23660.2.camel@wwguy-ubuntu> (raw)
In-Reply-To: <CALSq=Ba0-Jryh=cU5bp9MpeTtOAru3YqavuTtwuudjO2_Ri5Ag@mail.gmail.com>
On Tue, 2011-09-20 at 16:51 -0700, Daniel Halperin wrote:
> On Tue, Sep 20, 2011 at 3:37 PM, Wey-Yi Guy <wey-yi.w.guy@intel.com> wrote:
> >
> > From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> >
> > During my works on the transport layer I removed code that updated
> > a local variable (is_agg) that is needed to keep the pending_frames
> > count up to date. Fix this.
>
> Seems like a big bug.
>
> Is this a bugfix for a patch earlier in the series or a patch that's
> already been accepted. If the former, why not merge? If the latter,
> why not CC'ed as a fix to an earlier version of the kernel?
>
good point, I will work with Emmanuel to figure out if we need to
backport to the earlier kernel
Thanks for catch this one
Wey
next prev parent reply other threads:[~2011-09-21 0:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 22:37 [PATCH 0/8] update for 3.2 Wey-Yi Guy
2011-09-20 22:37 ` [PATCH 1/8] iwlagn: move scan code to scan file Wey-Yi Guy
2011-09-20 22:37 ` [PATCH 2/8] iwlagn: remove common station priv Wey-Yi Guy
2011-09-20 22:37 ` [PATCH 3/8] iwlagn: split remain-on-channel Wey-Yi Guy
2011-09-20 22:37 ` [PATCH 4/8] iwlagn: remove the callback in host commands Wey-Yi Guy
2011-09-20 22:37 ` [PATCH 5/8] iwlagn: simplify the iwl_device_cmd layout Wey-Yi Guy
2011-09-20 22:37 ` [PATCH 6/8] iwlagn: remove uneeded declaration Wey-Yi Guy
2011-09-20 22:37 ` [PATCH 7/8] iwlagn: pending frames musn't be incremented if agg is on Wey-Yi Guy
2011-09-20 23:51 ` Daniel Halperin
2011-09-21 0:35 ` wwguy [this message]
2011-09-21 5:06 ` Grumbach, Emmanuel
2011-09-20 22:37 ` [PATCH 8/8] iwlagn: remove duplicate list init Wey-Yi Guy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316565315.23660.2.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=dhalperi@cs.washington.edu \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox