linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luciano Coelho <coelho@ti.com>
To: Jouni Malinen <j@w1.fi>
Cc: Victor Goldenshtein <victorg@ti.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Subject: Re: [RFC 3/5] nl80211/cfg80211: adding intermediate scan result event.
Date: Wed, 21 Sep 2011 18:45:03 +0300	[thread overview]
Message-ID: <1316619903.2157.546.camel@cumari> (raw)
In-Reply-To: <20110921153102.GA32374@jm.kir.nu>

On Wed, 2011-09-21 at 18:31 +0300, Jouni Malinen wrote: 
> On Thu, Sep 08, 2011 at 09:31:01AM +0300, Victor Goldenshtein wrote:
> > You're right, cfg80211 drivers will not support it. As I couldn't
> > find a way to know whether it mac or cfg based driver, I can add
> > also IEEE80211_HW_SUPPORTS_IM_RESULT" flag (as with cancel_scan) and
> > then will advertise the nl80211 command if it set, is it OK?
> 
> Why would cfg80211 drivers not support this? There is already a pending
> patch set to make ath6kl report scan results during the scan with
> cfg80211_inform_bss_frame() so all it would need to do is to add another
> call for cfg80211_send_intermediate_result() to support this...

Yeah, I guess he didn't mean that no cfg80211 drivers support it, but
that some drivers may not support it.  At least this was what we
discussed privately. ;)


> That brings up a question: Do we need to have this new function or would it
> be feasible for cfg80211 to generate the intermediate reports
> automatically based on cfg80211_inform_bss{,_frame}() calls during the
> scan?

Very good point! Thinking of it, there is not need to add this new
function and have the drivers call it.  cfg80211 can find out when to
send the results by itself, whenever someone calls
cfg80211_inform_bss_frame(), by checking whether intermediate results
are enabled or not.

This will simplify the code. :) Thanks for your comments!

-- 
Cheers,
Luca.


  reply	other threads:[~2011-09-21 15:45 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 12:02 [RFC 0/5] Scan optimization Victor Goldenshtein
2011-09-05 12:02 ` [RFC v2 1/5] nl80211/cfg80211: adding 'scan_cancel' command Victor Goldenshtein
2011-09-05 12:05   ` Johannes Berg
     [not found]     ` <4E6736CE.20004@ti.com>
2011-09-07  9:26       ` Johannes Berg
2011-09-05 12:02 ` [RFC v2 2/5] mac80211: " Victor Goldenshtein
2011-09-05 12:06   ` Johannes Berg
2011-09-05 12:02 ` [RFC 3/5] nl80211/cfg80211: adding intermediate scan result event Victor Goldenshtein
2011-09-05 12:08   ` Johannes Berg
2011-09-05 12:08   ` Johannes Berg
     [not found]     ` <4E6736D9.3070804@ti.com>
2011-09-07  9:26       ` Johannes Berg
2011-09-08  6:31         ` Victor Goldenshtein
2011-09-08  6:49           ` Johannes Berg
2011-09-08  8:56             ` Victor Goldenshtein
2011-09-08  9:27               ` Johannes Berg
2011-09-08 14:39                 ` Victor Goldenshtein
2011-09-08 14:42                   ` Johannes Berg
2011-09-21 15:31           ` Jouni Malinen
2011-09-21 15:45             ` Luciano Coelho [this message]
2011-09-21 16:28               ` Victor Goldenshtein
2011-09-21 16:38                 ` Johannes Berg
2011-09-22  6:41                   ` Victor Goldenshtein
2011-09-22  6:49                     ` Luciano Coelho
2011-09-22  7:13                       ` Victor Goldenshtein
2011-09-22  7:15                         ` Luciano Coelho
2011-09-22  7:54                         ` Johannes Berg
2011-09-21  8:19   ` Victor Goldenshtein
2011-09-21  8:35     ` Johannes Berg
2011-09-21  9:03       ` Luciano Coelho
2011-09-21 10:16         ` Johannes Berg
2011-09-05 12:02 ` [RFC 4/5] mac80211: adding intermediate scan result event call Victor Goldenshtein
2011-09-05 12:02 ` [RFC 5/5] nl80211/cfg80211: adding intermediate scan result filter Victor Goldenshtein
2011-09-05 12:11   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316619903.2157.546.camel@cumari \
    --to=coelho@ti.com \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=victorg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).