From: ilanelias78@gmail.com
To: aloisio.almeida@openbossa.org, lauro.venancio@openbossa.org,
samuel@sortiz.org, linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, Ilan Elias <ilane@ti.com>
Subject: [PATCH] NFC: improve readability of an 'if' in nci core.c
Date: Thu, 22 Sep 2011 10:47:52 +0300 [thread overview]
Message-ID: <1316677672-4812-1-git-send-email-ilane@ti.com> (raw)
From: Ilan Elias <ilane@ti.com>
Signed-off-by: Ilan Elias <ilane@ti.com>
---
net/nfc/nci/core.c | 32 ++++++++++++++------------------
1 files changed, 14 insertions(+), 18 deletions(-)
diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c
index 895e5fd..c3dfd4e 100644
--- a/net/nfc/nci/core.c
+++ b/net/nfc/nci/core.c
@@ -135,8 +135,10 @@ static void nci_init_req(struct nci_dev *ndev, unsigned long opt)
static void nci_init_complete_req(struct nci_dev *ndev, unsigned long opt)
{
- struct nci_rf_disc_map_cmd cmd;
struct nci_core_conn_create_cmd conn_cmd;
+ struct nci_rf_disc_map_cmd cmd;
+ struct disc_map_config *cfg = cmd.mapping_configs;
+ __u8 *num = &cmd.num_mapping_configs;
int i;
/* create static rf connection */
@@ -145,36 +147,30 @@ static void nci_init_complete_req(struct nci_dev *ndev, unsigned long opt)
nci_send_cmd(ndev, NCI_OP_CORE_CONN_CREATE_CMD, 2, &conn_cmd);
/* set rf mapping configurations */
- cmd.num_mapping_configs = 0;
+ *num = 0;
/* by default mapping is set to NCI_RF_INTERFACE_FRAME */
for (i = 0; i < ndev->num_supported_rf_interfaces; i++) {
if (ndev->supported_rf_interfaces[i] ==
NCI_RF_INTERFACE_ISO_DEP) {
- cmd.mapping_configs[cmd.num_mapping_configs]
- .rf_protocol = NCI_RF_PROTOCOL_ISO_DEP;
- cmd.mapping_configs[cmd.num_mapping_configs]
- .mode = NCI_DISC_MAP_MODE_BOTH;
- cmd.mapping_configs[cmd.num_mapping_configs]
- .rf_interface_type = NCI_RF_INTERFACE_ISO_DEP;
- cmd.num_mapping_configs++;
+ cfg[*num].rf_protocol = NCI_RF_PROTOCOL_ISO_DEP;
+ cfg[*num].mode = NCI_DISC_MAP_MODE_BOTH;
+ cfg[*num].rf_interface_type = NCI_RF_INTERFACE_ISO_DEP;
+ (*num)++;
} else if (ndev->supported_rf_interfaces[i] ==
NCI_RF_INTERFACE_NFC_DEP) {
- cmd.mapping_configs[cmd.num_mapping_configs]
- .rf_protocol = NCI_RF_PROTOCOL_NFC_DEP;
- cmd.mapping_configs[cmd.num_mapping_configs]
- .mode = NCI_DISC_MAP_MODE_BOTH;
- cmd.mapping_configs[cmd.num_mapping_configs]
- .rf_interface_type = NCI_RF_INTERFACE_NFC_DEP;
- cmd.num_mapping_configs++;
+ cfg[*num].rf_protocol = NCI_RF_PROTOCOL_NFC_DEP;
+ cfg[*num].mode = NCI_DISC_MAP_MODE_BOTH;
+ cfg[*num].rf_interface_type = NCI_RF_INTERFACE_NFC_DEP;
+ (*num)++;
}
- if (cmd.num_mapping_configs == NCI_MAX_NUM_MAPPING_CONFIGS)
+ if (*num == NCI_MAX_NUM_MAPPING_CONFIGS)
break;
}
nci_send_cmd(ndev, NCI_OP_RF_DISCOVER_MAP_CMD,
- (1 + (cmd.num_mapping_configs*sizeof(struct disc_map_config))),
+ (1 + ((*num)*sizeof(struct disc_map_config))),
&cmd);
}
--
1.7.0.4
next reply other threads:[~2011-09-22 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 7:47 ilanelias78 [this message]
2011-09-26 20:59 ` [PATCH] NFC: improve readability of an 'if' in nci core.c Lauro Ramos Venancio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316677672-4812-1-git-send-email-ilane@ti.com \
--to=ilanelias78@gmail.com \
--cc=aloisio.almeida@openbossa.org \
--cc=ilane@ti.com \
--cc=lauro.venancio@openbossa.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox