From: Johannes Berg <johannes@sipsolutions.net>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Jouni Malinen <jouni@qca.qualcomm.com>
Subject: Re: [RFC 1/2] nl80211/cfg80211: Add support to disable CCK rate for management frame
Date: Fri, 23 Sep 2011 12:20:32 +0200 [thread overview]
Message-ID: <1316773232.4058.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1316703516-24216-1-git-send-email-rmanohar@qca.qualcomm.com>
On Thu, 2011-09-22 at 20:28 +0530, Rajkumar Manoharan wrote:
Looks fine, minor nitpick:
> + request->no_cck = nla_get_flag(info->attrs
> + [NL80211_ATTR_TX_NO_CCK_RATE]);
I think that'd be nicer as
request->no_cck =
nla_get_flag(...);
even if potentially that goes above 80 cols.
> + no_cck = nla_get_flag(info->attrs[NL80211_ATTR_TX_NO_CCK_RATE]);
Or I guess it probably won't if this fits :)
Thanks!
johannes
prev parent reply other threads:[~2011-09-23 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 14:58 [RFC 1/2] nl80211/cfg80211: Add support to disable CCK rate for management frame Rajkumar Manoharan
2011-09-22 14:58 ` [RFC 2/2] mac80211: Send the management frame at requested rate Rajkumar Manoharan
2011-09-23 10:22 ` Johannes Berg
2011-09-23 10:23 ` Johannes Berg
2011-09-23 10:20 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316773232.4058.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).