From: Johannes Berg <johannes@sipsolutions.net>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] mac80211: pass vif param to conf_tx() callback
Date: Mon, 26 Sep 2011 11:36:26 +0200 [thread overview]
Message-ID: <1317029786.4117.30.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1316970415-23239-3-git-send-email-eliad@wizery.com> (sfid-20110925_190733_679283_5E6C4322)
On Sun, 2011-09-25 at 20:06 +0300, Eliad Peller wrote:
> tx params should be configured per interface.
> Add ieee80211_vif param to the conf_tx callback,
> and update all the drivers that use this callback.
>
> The following spatch was used:
> @rule1@
> struct ieee80211_ops ops;
> identifier conf_tx_op;
> @@
> ops.conf_tx = conf_tx_op;
>
> @rule2@
> identifier rule1.conf_tx_op;
> identifier hw, queue, params;
> @@
> conf_tx_op (
> - struct ieee80211_hw *hw,
> + struct ieee80211_hw *hw, struct ieee80211_vif *vif,
> u16 queue,
> const struct ieee80211_tx_queue_params *params) {...}
Nice :-)
Looks good to me. (all 3)
johannes
next prev parent reply other threads:[~2011-09-26 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-25 17:06 [PATCH 1/3] cfg80211/mac80211: add netdev param to set_txq_params() Eliad Peller
2011-09-25 17:06 ` [PATCH 2/3] mac80211: save tx params per sdata Eliad Peller
2011-09-25 17:06 ` [PATCH 3/3] mac80211: pass vif param to conf_tx() callback Eliad Peller
2011-09-26 9:36 ` Johannes Berg [this message]
2011-09-28 13:48 ` Johannes Berg
2011-09-30 18:43 ` John W. Linville
2011-09-30 19:57 ` John W. Linville
2011-10-02 7:55 ` Eliad Peller
2011-09-26 9:34 ` [PATCH 1/3] cfg80211/mac80211: add netdev param to set_txq_params() Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317029786.4117.30.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).