From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: linux-wireless@vger.kernel.org, Kalyan C Gaddam <chakkal@iit.edu>
Subject: Re: [PATCH 3/5] mac80211: handle TDLS high-level commands and frames
Date: Tue, 27 Sep 2011 13:50:07 +0200 [thread overview]
Message-ID: <1317124207.4082.20.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1317034493-5300-4-git-send-email-arik@wizery.com> (sfid-20110926_125515_791883_21717CE9)
On Mon, 2011-09-26 at 13:54 +0300, Arik Nemtsov wrote:
> +/*
> + * TDLS capabililites to be enabled in the 5th byte of the
> + * @WLAN_EID_EXT_CAPABILITY information element
> + */
> +#define WLAN_EXT_CAPA_TDLS_ENABLED BIT(5)
> +#define WLAN_EXT_CAPA_TDLS_PROHIBITED BIT(6)
Would it be useful to have the IE declared as a struct somewhere?
> +static int
> +ieee80211_prep_tdls_encap_data(struct wiphy *wiphy, struct net_device *dev,
> + u8 *peer, u8 action_code, u8 dialog_token,
> + u16 status_code, struct sk_buff *skb)
All the code addition here makes me wonder if it'd be useful to move it
into a new tdls.c file and just call the right hooks from cfg.c? the cfg
file is pretty large already ... tdls wouldn't be huge, but still might
make sense?
johannes
next prev parent reply other threads:[~2011-09-27 11:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 10:54 [PATCH 0/5] TDLS support for nl80211/mac80211 drivers Arik Nemtsov
2011-09-26 10:54 ` [PATCH 1/5] nl80211: support sending TDLS commands/frames Arik Nemtsov
2011-09-27 11:43 ` Johannes Berg
2011-09-26 10:54 ` [PATCH 2/5] mac80211: standardize adding supported rates IEs Arik Nemtsov
2011-09-27 11:46 ` Johannes Berg
2011-09-27 21:08 ` Arik Nemtsov
2011-09-26 10:54 ` [PATCH 3/5] mac80211: handle TDLS high-level commands and frames Arik Nemtsov
2011-09-27 11:50 ` Johannes Berg [this message]
2011-09-27 21:12 ` Arik Nemtsov
2011-09-26 10:54 ` [PATCH 4/5] nl80211/mac80211: allow adding TDLS peers as stations Arik Nemtsov
2011-09-27 11:55 ` Johannes Berg
2011-09-27 21:24 ` Arik Nemtsov
2011-09-26 10:54 ` [PATCH 5/5] mac80211: data path modification for TDLS peers Arik Nemtsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317124207.4082.20.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=chakkal@iit.edu \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox