From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] mac80211: Allow NO_ACK flag overwrite for injected frames
Date: Thu, 29 Sep 2011 11:59:35 +0200 [thread overview]
Message-ID: <1317290375.3974.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1317288432-26380-1-git-send-email-helmut.schaa@googlemail.com> (sfid-20110929_112749_887836_A27DE080)
On Thu, 2011-09-29 at 11:27 +0200, Helmut Schaa wrote:
> Allow injected unicast frames to be sent without having to wait
> for an ACK.
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> ---
>
> Just in case you're interested in what's the intended purpose of this:
>
> Some clients are staying on scanned channels for a very short period of
> time. hostapd sends out probe responses for each configured BSSID. Under
> some circumstances I can see that the client already left the channel
> while some probe responses are still sent out and thus retried. This
> consumes quite some airtime. Commercial wireless APs (Aruba for example)
> seem to disable retries for probe responses to mitigate such issues.
Makes sense, but I wonder if we really should continue using
radiotap :-) Maybe mgmt-tx in nl80211 would be appropriate.
> @@ -1257,7 +1265,7 @@ ieee80211_tx_prepare(struct ieee80211_sub_if_data *sdata,
> tx->flags |= IEEE80211_TX_UNICAST;
> if (unlikely(local->wifi_wme_noack_test))
> info->flags |= IEEE80211_TX_CTL_NO_ACK;
> - else
> + else if (!(info->flags & IEEE80211_TX_CTL_NO_ACK))
> info->flags &= ~IEEE80211_TX_CTL_NO_ACK;
??
johannes
next prev parent reply other threads:[~2011-09-29 9:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 9:27 [PATCH] mac80211: Allow NO_ACK flag overwrite for injected frames Helmut Schaa
2011-09-29 9:59 ` Johannes Berg [this message]
2011-09-29 10:02 ` Helmut Schaa
2011-09-29 10:21 ` Johannes Berg
2011-09-29 10:50 ` Helmut Schaa
2011-09-29 11:42 ` [PATCHv2] mac80211: Allow noack " Helmut Schaa
2011-10-27 19:30 ` Johannes Berg
2011-10-28 3:46 ` Helmut Schaa
2011-10-07 8:56 ` [PATCH] mac80211: Allow NO_ACK " Johannes Berg
2011-10-07 9:43 ` Helmut Schaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317290375.3974.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox