Re: [PATCH 1/2] wl12xx: sdio: use dev_dbg instead of wl1271_debug

[Luciano Coelho <coelho@ti.com>]

On Sun, 2011-10-09 at 02:08 +0200, Eliad Peller wrote: 
> On Fri, Oct 7, 2011 at 1:34 PM, Luciano Coelho <coelho@ti.com> wrote:
> > To prevent a useless dependency between the sdio module and the wl12xx
> > module, we need to replace the wl1271_debug macros (and friends) for
> > dev_dbg and other equivalents.
> >
> > At the same time, remove the SDIO data hexdump, since this produces
> > way too much data and is not particularly useful.  There's not
> > print_hex_dump() equivalent for dynamic debug, so it's hard to control
> > when the dumps are printed out.
> >
> > Signed-off-by: Luciano Coelho <coelho@ti.com>
> > ---
> [...]
> >                if (!(sdio_flags & MMC_PM_KEEP_POWER)) {
> > -                       wl1271_error("can't keep power while host "
> > +                       dev_err(dev, "can't keep power while host \n"
> >                                     "is suspended");
> 
> you missed the concatenation here :)

Ouch! Et tu Brutus?! :)

My regex didn't spread across lines.  I'll fix it, thanks for checking.


-- 
Cheers,
Luca.