From: Johannes Berg <johannes@sipsolutions.net>
To: Dmitry Tarnyagin <abi.dmitryt@gmail.com>
Cc: "linux-wireless.vger.kernel.org" <linux-wireless@vger.kernel.org>,
Bartosz MARKOWSKI <bartosz.markowski@tieto.com>,
Janusz DZIEDZIC <janusz.dziedzic@tieto.com>
Subject: Re: [RFC 04/07] compat-wireless: p2p power save support
Date: Wed, 12 Oct 2011 10:30:58 +0200 [thread overview]
Message-ID: <1318408258.3933.27.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <op.v27ruwj6ya27un@edmitar> (sfid-20111012_030253_319878_2BE5AA16)
On Wed, 2011-10-12 at 03:02 +0200, Dmitry Tarnyagin wrote:
> From: Janusz Dziedzic <janusz.dziedzic@tieto.com>
> Date: Thu, 4 Aug 2011 11:42:16 +0200
>
> P2P power save support:
> - Opportunistic Power Save
> - Notice Of Absence
More explanation please. I know I sound like a broken record but for
such a big change you really need more text.
I'm not even going to bother to review the patch in detail. You need to
explain why you need to set NoA. There are three reasons this would be
used:
1) actually save power
2) do scanning, multi-channel operation, etc.
3) P2P certification testing
Only 3) seems to be useful from userspace, and then maybe it shouldn't
be full-blown nl80211 API.
Similarly for the P2P power save stuff. Since you generally lack
documentation updates in your patches (read this as criticism) there's
no way reason to even look through your patches since they don't explain
anything.
FWIW, a very brief glance over this patch tells me that there's at least
one obvious, glaring bug in it.
johannes
prev parent reply other threads:[~2011-10-12 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 1:02 [RFC 04/07] compat-wireless: p2p power save support Dmitry Tarnyagin
2011-10-12 3:17 ` Julian Calaby
2011-10-12 8:30 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318408258.3933.27.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=abi.dmitryt@gmail.com \
--cc=bartosz.markowski@tieto.com \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).