From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-dy0-f46.google.com ([209.85.220.46]:51563 "EHLO mail-dy0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301Ab1JLVSW (ORCPT ); Wed, 12 Oct 2011 17:18:22 -0400 Received: by dyf4 with SMTP id 4so37526dyf.19 for ; Wed, 12 Oct 2011 14:18:21 -0700 (PDT) From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: linux-wireless@vger.kernel.org, "John W. Linville" Cc: b43-dev@lists.infradead.org, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Subject: [PATCH 3.2 1/2] Revert "b43: trivial: do not report any link quality instead of invalid one" Date: Wed, 12 Oct 2011 23:18:14 +0200 Message-Id: <1318454295-20573-1-git-send-email-zajec5@gmail.com> (sfid-20111012_231826_138755_FB681DCE) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: This reverts commit 55ad5962e97430c83d51df36fc18865ee4f78c48. I assumed N is newer than LP, which isn't true. This regressed LP case. Signed-off-by: Rafał Miłecki --- It seems that wasn't so "trivial", sorry for this regression :| --- drivers/net/wireless/b43/xmit.c | 12 +++++------- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/b43/xmit.c b/drivers/net/wireless/b43/xmit.c index 5f812d1..b8de62c 100644 --- a/drivers/net/wireless/b43/xmit.c +++ b/drivers/net/wireless/b43/xmit.c @@ -735,13 +735,11 @@ void b43_rx(struct b43_wldev *dev, struct sk_buff *skb, const void *_rxhdr) } /* Link quality statistics */ - if ((chanstat & B43_RX_CHAN_PHYTYPE) >= B43_PHYTYPE_N) { - /* - s8 rssi = max(rxhdr->power0, rxhdr->power1); - TODO: Find out what the rssi value is (dBm or percentage?) - and also find out what the maximum possible value is. - Fill status.ssi and status.signal fields. - */ + if ((chanstat & B43_RX_CHAN_PHYTYPE) == B43_PHYTYPE_N) { +// s8 rssi = max(rxhdr->power0, rxhdr->power1); + //TODO: Find out what the rssi value is (dBm or percentage?) + // and also find out what the maximum possible value is. + // Fill status.ssi and status.signal fields. } else { status.signal = b43_rssi_postprocess(dev, rxhdr->jssi, (phystat0 & B43_RX_PHYST0_OFDM), -- 1.7.3.4