Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ivan Bezyazychnyy <ivan.bezyazychnyy@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 4/7] mac80211: setting link-specific mesh power modes when plink open
Date: Fri, 21 Oct 2011 12:05:02 +0200	[thread overview]
Message-ID: <1319191502.3964.11.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAG5dHkT8fPodB_ejoqSmH4Dgr-ynuMzwo5r5czXfCWgJWLiS=w@mail.gmail.com> (sfid-20111021_103730_949262_32D1DC8A)

On Fri, 2011-10-21 at 12:37 +0400, Ivan Bezyazychnyy wrote:
> Setting peer link-specific power mode equal to peer non-peer power mode
> value and local link-specific power mode equal to local non-peer value

You really need more verbose changelogs, I can't even parse that
properly. How about mentioning why, what it means, etc?

You should also extend your cover letter to explain how the power save
stuff works.

johannes


  reply	other threads:[~2011-10-21 10:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21  8:37 [RFC 4/7] mac80211: setting link-specific mesh power modes when plink open Ivan Bezyazychnyy
2011-10-21 10:05 ` Johannes Berg [this message]
2011-10-23 13:12   ` Ivan Bezyazychnyy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319191502.3964.11.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ivan.bezyazychnyy@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox