From: Johannes Berg <johannes@sipsolutions.net>
To: Guy Eilam <guy@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/4] nl80211: Add probe response offload attribute
Date: Sat, 22 Oct 2011 15:34:17 +0200 [thread overview]
Message-ID: <1319290457.3956.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1319289112-21896-1-git-send-email-guy@wizery.com> (sfid-20111022_151410_304888_4D10E8E6)
On Sat, 2011-10-22 at 15:11 +0200, Guy Eilam wrote:
> +enum nl80211_probe_resp_offload_support_attr {
> + NL80211_PROBE_RESP_OFFLOAD_SUPPORT_WPS,
> + NL80211_PROBE_RESP_OFFLOAD_SUPPORT_WPS2,
> + NL80211_PROBE_RESP_OFFLOAD_SUPPORT_P2P,
> +};
I think doing = 1<<N here would be nicer to use in drivers & userspace.
> + * @get_probe_resp_offload: Get probe response offload support from driver.
and this seems unnecessary -- why not just put a u32 value into struct
wiphy?
johannes
next prev parent reply other threads:[~2011-10-22 13:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-22 13:11 [PATCH 1/4] nl80211: Add probe response offload attribute Guy Eilam
2011-10-22 13:11 ` [PATCH 2/4] mac80211: Get the probe response offloading support from the driver Guy Eilam
2011-10-22 13:11 ` [PATCH 3/4] nl80211: Pass probe response data to drivers Guy Eilam
2011-10-22 13:11 ` [PATCH 4/4] mac80211: Save probe response data for BSS Guy Eilam
2011-10-22 13:34 ` Johannes Berg [this message]
2011-10-22 13:36 ` [PATCH 1/4] nl80211: Add probe response offload attribute Johannes Berg
2011-10-22 17:26 ` Guy Eilam
2011-10-22 17:39 ` Johannes Berg
2011-10-22 17:42 ` Guy Eilam
2011-10-22 17:44 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319290457.3956.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=guy@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox