From: Johannes Berg <johannes@sipsolutions.net>
To: Dmitry Tarnyagin <abi.dmitryt@gmail.com>
Cc: Dan Williams <dcbw@redhat.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-wireless@vger.kernel.org
Subject: Re: A new driver is going to be released
Date: Fri, 04 Nov 2011 10:20:12 +0100 [thread overview]
Message-ID: <1320398412.3969.18.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAMG6FYjGDhts2K3gYSeh0HACkFgSxxXZYdRCHrYp=2W3LceoyQ@mail.gmail.com> (sfid-20111104_101035_860741_ABCAE9E8)
On Fri, 2011-11-04 at 10:10 +0100, Dmitry Tarnyagin wrote:
> Hi Johannes,
>
> >> Correct. But I would move it to drivers/net/wireless during submission.
> >
> > A word of caution: don't attempt that in its current state.
> >
> Thank you for caution. CONFIG_CW1200_USE_STE_EXTENSIONS,
> CONFIG_WAKELOCK and HAS_PUT_TASK_STRUCT will be removed
> of course, API will be aligned with 3.1. But I'm a bit curious what else could
> prevent from submission to drivers/net/wireless? I do not see obvious problems
> with code. Could you please give a short advise what should be fixed then if you
> see problems?
Well there is a ton of stuff like compat code too. Also, for example the
worker thread is pretty strange -- kthread_create() is essentially
deprecated, and having a thread to handle interrupts is weird to start
with.
johannes
next prev parent reply other threads:[~2011-11-04 9:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 22:40 A new driver is going to be released Dmitry Tarnyagin
2011-11-04 1:09 ` Larry Finger
2011-11-04 2:01 ` Dan Williams
2011-11-04 5:32 ` Dmitry Tarnyagin
2011-11-04 8:12 ` Johannes Berg
2011-11-04 9:10 ` Dmitry Tarnyagin
2011-11-04 9:20 ` Johannes Berg [this message]
2011-11-04 14:54 ` Larry Finger
2011-11-04 8:06 ` Kalle Valo
2011-11-04 9:13 ` Vitaly Wool
2011-11-04 9:18 ` Kalle Valo
2012-02-28 5:45 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320398412.3969.18.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=abi.dmitryt@gmail.com \
--cc=dcbw@redhat.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).