From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz.Dziedzic@tieto.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: uAPSD - fix IEEE80211_FCTL_MOREDATA bit setting
Date: Mon, 07 Nov 2011 09:50:08 +0100 [thread overview]
Message-ID: <1320655808.3993.13.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <3078A9B976EF864C8DDD0C499FFD07911E3B56E1EC@EXMB01.eu.tieto.com>
On Mon, 2011-11-07 at 09:47 +0200, Janusz.Dziedzic@tieto.com wrote:
> Set IEEE80211_FCTL_MOREDATA bit also in case we have buffered
> frames (more than one) only for one AC.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Thanks!
> ---
> net/mac80211/sta_info.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
> index ce962d2..8eaa746 100644
> --- a/net/mac80211/sta_info.c
> +++ b/net/mac80211/sta_info.c
> @@ -1354,12 +1354,12 @@ ieee80211_sta_ps_deliver_response(struct sta_info *sta,
> * Use MoreData flag to indicate whether there are
> * more buffered frames for this STA
> */
> - if (!more_data)
> - hdr->frame_control &=
> - cpu_to_le16(~IEEE80211_FCTL_MOREDATA);
> - else
> + if (more_data || !skb_queue_empty(&frames))
> hdr->frame_control |=
> cpu_to_le16(IEEE80211_FCTL_MOREDATA);
> + else
> + hdr->frame_control &=
> + cpu_to_le16(~IEEE80211_FCTL_MOREDATA);
>
> if (ieee80211_is_data_qos(hdr->frame_control) ||
> ieee80211_is_qos_nullfunc(hdr->frame_control))
prev parent reply other threads:[~2011-11-07 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 7:47 [PATCH] mac80211: uAPSD - fix IEEE80211_FCTL_MOREDATA bit setting Janusz.Dziedzic
2011-11-07 8:50 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320655808.3993.13.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Janusz.Dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox