From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Lukasz Jagiello <jagiello.lukasz@gmail.com>
Subject: Re: [PATCH v2] mac80211: disassociate when direct probe timed out
Date: Mon, 07 Nov 2011 16:42:32 +0100 [thread overview]
Message-ID: <1320680552.3993.46.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20111107153410.GB5990@redhat.com>
On Mon, 2011-11-07 at 16:34 +0100, Stanislaw Gruszka wrote:
> +++ b/net/mac80211/mlme.c
> @@ -2379,8 +2379,14 @@ ieee80211_probe_auth_done(struct ieee80211_work *wk,
> struct sk_buff *skb)
> {
> struct ieee80211_local *local = wk->sdata->local;
> + struct ieee80211_if_managed *ifmgd = &wk->sdata->u.mgd;
>
> if (!skb) {
> + mutex_lock(&ifmgd->mtx);
> + if (ifmgd->associated)
> + ieee80211_set_disassoc(wk->sdata, true, false);
> + mutex_unlock(&ifmgd->mtx);
> +
> cfg80211_send_auth_timeout(wk->sdata->dev, wk->filter_ta);
> goto destroy;
> }
This doesn't seem right -- we can authenticate with a new AP while
connected to an old one, but if the connection to the new one fails why
should we tear down the connection to the *old* one?
johannes
next prev parent reply other threads:[~2011-11-07 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 14:26 [PATCH] mac80211: disassociate when direct probe timed out Stanislaw Gruszka
2011-11-07 15:29 ` Stanislaw Gruszka
2011-11-07 15:34 ` [PATCH v2] " Stanislaw Gruszka
2011-11-07 15:42 ` Johannes Berg [this message]
2011-11-07 15:43 ` Johannes Berg
2011-11-07 16:00 ` Stanislaw Gruszka
2011-11-07 16:05 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320680552.3993.46.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jagiello.lukasz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).