Re: [PATCH v4 1/2] wireless: Support ht-capabilities over-rides.

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2011-11-07 at 08:27 -0800, Ben Greear wrote:

> >> +	kfree(rdev->wiphy.ht_capa_mod_mask);
> >> +	rdev->wiphy.ht_capa_mod_mask = NULL;
> >
> > That doesn't seem right -- drivers should typically assign a static
> > const variable to this pointer that can't be freed.
> 
> Earlier I think you argued that all of mac80211 drivers automatically supported
> these features as long as I put in the limitations that certain values
> could only be increased and certain only decreased, etc.
> 
> So, I put it in the mac80211 code instead of down in the drivers.
> But, I can move it into ath9k if you prefer.

Err, no -- if I'm talking about "drivers" from cfg80211's point of view,
mac80211 is one of those "drivers"! This comment was only about the
weird way of freeing it and static const etc.

johannes