Re: [PATCH v4 2/2] mac80211: Support ht-cap over-rides.

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2011-11-07 at 08:19 -0800, Ben Greear wrote:

> > Why is this not just a static const that you fill manually? There's
> > nothing that's not constant here. So e.g.
> >
> > static const struct ieee80211_ht_cap mac80211_ht_capa_mod_mask = {
> > 	.ampdu_params_info = IEEE80211_HT_AMPDU_PARM_FACTOR |
> > 			     IEEE80211_HT_AMPDU_PARM_DENSITY,
> > 	.mcs = {
> > 		.rx_mask = { 0xff, 0xff, 0xff, 0xff, 0xff,
> > 			     0xff, 0xff, 0xff, 0xff, 0xff, },
> > 	},
> > 	/* etc */
> > };
> 
> Well, you suggested a pointer in the wiphy struct that was null
> for non mac80211 interfaces.  I'm not sure how to distinguish between
> mac80211 and other wiphys when reporting the capabilities if I use
> this global static.  I also like that the non-static logic lets
> us tweak this for individual drivers if that becomes an issue.

Right. So if you assign this pointer in alloc_hw() then the driver can
still override it before register_hw(). I don't see at all why it needs
to be dynamically allocated.

johannes